Upgrade to Angular 16 #1993
Upgrade to Angular 16 #1993
Conversation
| @@ -19,6 +19,9 @@ | |||
| "plugin:@angular-eslint/recommended", | |||
| "plugin:@angular-eslint/template/process-inline-templates" | |||
| ], | |||
| "plugins": [ | |||
There was a problem hiding this comment.
I'm a little unclear on why this is now needed or why it wasn't needed before. npm run lint fails now without it.
| @@ -143,7 +143,7 @@ | |||
| class="accent-1-dark-btn" | |||
| type="button" | |||
| (click)="addToExistingTools()" | |||
| [disabled]="(isRefreshing$ | async) || (userQuery.user$ | async) === false" | |||
| [disabled]="(isRefreshing$ | async) || (userQuery.user$ | async) === null" | |||
There was a problem hiding this comment.
The compiler started complaining about this, rightly so, userQuery.user$'s type is not a boolean. There are other similar instances of this that were also changed.
| @@ -150,6 +150,7 @@ export class MyToolComponent extends MyEntry implements OnInit { | |||
| this.router.events | |||
| .pipe( | |||
| filter((event) => event instanceof NavigationEnd), | |||
| map((event) => event as NavigationEnd), | |||
There was a problem hiding this comment.
Compiler complained without adding this. I guess Angular 16 compiler is stricter about some things.
will build on Angular 15.
1. Noticed mocks have extra fields, unlikely to make a difference 2. Try scrollTo, looks like it may be partially cut off in video 3. Use data-cy with new id as selector; lame theory that the register workflow dialog had been invoked, and it has the same id
coverbeck
force-pushed
the
feature/seab-6140/16
branch
from
506c753 to
89ca622
Compare
because it uses legacy Material, which the rest of our app uses.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1993 +/- ##
========================================
Coverage 41.99% 41.99%
========================================
Files 388 388
Lines 12179 12179
Branches 2926 2923 -3
========================================
Hits 5114 5114
+ Misses 4775 4774 -1
- Partials 2290 2291 +1 ☔ View full report in Codecov by Sentry. |
| }, | ||
| "overrides": { | ||
| "@schematics/update": { | ||
| "ini": "^1.3.8" | ||
| }, | ||
| "ngx-mat-select-search": { |
There was a problem hiding this comment.
There is a newer ngx-mat-select-search that works out of the box with Angular 16, but it uses the new Material components, and we're still on the legacy material components.
Description
Upgrades to Angular 16.
Review Instructions
Make sure the site is working correctly. Ideally the smoke tests should catch anything.
Issue
SEAB-6140
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run buildmarkdown-wrappercomponent, which does extra sanitizationnpm auditand ensure you are not introducing new vulnerabilities