Skip to content

Conversation

lanterno
Copy link
Contributor

@lanterno lanterno commented Aug 29, 2025

closes #15

Description

The docknetwork crypto libraries have moved ahead, and with 3 new minor versions. This PR updates those libraries only by one version, and two more PRs are coming to update these libraries to the latest versions.

In multiple cases, we've noticed that the API of the dock crypto crates have changed a bit, (mostly typing except in one case). We've updated those types, and added the missing methods, to make sure all tests pass as before. Please review these changes carefully, as I could delve deeper into how why work to make the best judgment.

Image

PR checklist

  • Run yarn install; yarn build; yarn test to make sure everything runs as before.
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Does this PR introduce a breaking change?

  • Yes
  • [] No

I had to let go of the legacy proof system as it used an out-of-date wasmer version that is incompatible with the new versions of the libraries

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@lanterno
Copy link
Contributor Author

@lovesh Please let me know if I should change something. I lack a lot of knowledge so the fixes might not be in the best shape. 🙏

@lovesh
Copy link
Collaborator

lovesh commented Aug 31, 2025

Thanks @lanterno 🙏

@lovesh lovesh merged commit 8325691 into docknetwork:master Aug 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating docknetwork libraries to next version (ex. bbs_plus 0.23)

2 participants