Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only exclude the buggy "requests" release #469

Closed
wants to merge 1 commit into from
Closed

Only exclude the buggy "requests" release #469

wants to merge 1 commit into from

Conversation

noirbizarre
Copy link

The commit 9e295d6 force "requests" version lower than 2.5.0 because of an urllib3 bug.
The version 2.5.1 (http://docs.python-requests.org/en/latest/community/updates/#id1) seems to fix the issue so it's better to only exclude the faulty release allowing user to upgrade requests above 2.5.1.

@noirbizarre noirbizarre changed the title Only exclude the buggy requests release Only exclude the buggy "requests" release Jan 30, 2015
@shin-
Copy link
Contributor

shin- commented Feb 1, 2015

I don't see it in the Changelog, can you link to the specific issue?

@gtaylor
Copy link
Contributor

gtaylor commented Feb 4, 2015

Thinking he may be talking about the Python 3-specific issue outlined here kennethreitz/requests/pull/2344

This looked like the fix: kennethreitz/requests@bd3cf95

@shin-
Copy link
Contributor

shin- commented Feb 4, 2015

Okay, the issue we're trying to avoid is the one documented in #406 . If someone using boot2docker can test this specifically with requests 2.5.1 and confirm that it's been fixed, I'll be happy to merge this, but I don't see any explicit mention of this.

@CleanCut
Copy link

@shin- If you or someone else would provide me with the steps to test #406, I would be happy to run through the procedures and report back. (How to test #406 isn't obvious to me). This issue is currently interrupting things in my department though, so I'd be happy to help out.

@GeyseR
Copy link

GeyseR commented Feb 19, 2015

Hi!
This issue touches our company development process, so I've tried to reproduce issue #406 on my boot2docker mac os installation. But with no luck.
My installation:

geyser$ boot2docker version
Boot2Docker-cli version: v1.5.0
Git commit: ccd9032

geyser$ boot2docker --vm="test-vm" init

geyser$ boot2docker --vm="test-vm" up
Waiting for VM and Docker daemon to start...
.o
Started.
Writing /Users/geyser/.boot2docker/certs/test-vm/ca.pem
Writing /Users/geyser/.boot2docker/certs/test-vm/cert.pem
Writing /Users/geyser/.boot2docker/certs/test-vm/key.pem

To connect the Docker client to the Docker daemon, please set:
    export DOCKER_HOST=tcp://192.168.59.103:2376
    export DOCKER_CERT_PATH=/Users/geyser/.boot2docker/certs/test-vm
    export DOCKER_TLS_VERIFY=1

geyser$ export DOCKER_HOST=tcp://192.168.59.103:2376
geyser$ export DOCKER_CERT_PATH=/Users/geyser/.boot2docker/certs/test-vm
geyser$ export DOCKER_TLS_VERIFY=1

geyser$ pip freeze
docker-py==1.0.0
requests==2.5.0
six==1.9.0

geyser$ python
Python 3.4.2 (v3.4.2:ab2c023a9432, Oct  5 2014, 20:42:22)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import docker
>>> from docker.client import Client
>>> from docker.utils import kwargs_from_env
>>> client = docker.Client(**kwargs_from_env())

Same results I have with Python 2/3, requests 2.5.0/2.5.1. Does anyone can confirm that this problem exists?

@shin-
Copy link
Contributor

shin- commented Mar 5, 2015

9bed480

@shin- shin- closed this Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants