Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requests version range #1026

Merged
merged 1 commit into from
Feb 25, 2015
Merged

Conversation

aanand
Copy link

@aanand aanand commented Feb 25, 2015

It was more permissive than docker-py's, resulting in an incompatible version (2.5.x) being installed.

Long-term, docker-py should update its requirement (see docker/docker-py#469) and we should update docker-py (see #997, for example) but this is critical as docker-compose 1.1.0-rc2 on PyPi is broken.

Closes #918.

It was more permissive than docker-py's, resulting in an incompatible
version (2.5.x) being installed.

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@aanand aanand added this to the 1.1.0 milestone Feb 25, 2015
@bfirsh
Copy link

bfirsh commented Feb 25, 2015

LGTM

bfirsh added a commit that referenced this pull request Feb 25, 2015
@bfirsh bfirsh merged commit 59c45e3 into docker:master Feb 25, 2015
@aanand aanand deleted the fix-requests-version-range branch February 25, 2015 17:51
@Glideh
Copy link

Glideh commented Mar 17, 2015

$ sudo pip install docker-compose --upgrade

Requirement already up-to-date: docker-compose
[...]
Requirement already up-to-date: requests>=2.2.1,<3 in /usr/local/lib/python2.7/dist-packages (from docker-compose)

$ docker-compose

pkg_resources.VersionConflict: (requests 2.6.0 (/usr/local/lib/python2.7/dist-packages), Requirement.parse('requests>=2.2.1,<2.5.0'))

I also cleared the cache from /tmp/pip-build-root/ (Using Mint)

yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Fix requests version range
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'requests' version conflict
3 participants