Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new errors for unsupported driver behaviors #1188

Merged
merged 3 commits into from
Aug 5, 2022

Commits on Aug 2, 2022

  1. kubernetes: error about unused endpoint argument

    Signed-off-by: Justin Chadwell <me@jedevc.com>
    jedevc committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    7ab3dc0 View commit details
    Browse the repository at this point in the history
  2. buildx: forbid mismatched drivers

    This patch reorders+refactors the runCreate function to ensure that we
    can detect and notify the user in the scenario that the user attempts to
    combine multiple drivers in a single builder, which is an unsupported
    scenario.
    
    Previously, we would just overwrite the previous builder with the new
    driver, potentially invalidating the already existing nodes.
    
    Signed-off-by: Justin Chadwell <me@jedevc.com>
    jedevc committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    3f5974b View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. buildx: warn on editing nodes

    Previously, editing nodes to contain a new set of driver options or
    config files was unsupported, and silently dropping them. In this patch,
    we update with these, as well as add a new warning message that any new
    options may not taken into account until the builder restarts (which
    may apply to the flags, platforms and endpoints as well).
    
    Signed-off-by: Justin Chadwell <me@jedevc.com>
    jedevc committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    ef0cbf2 View commit details
    Browse the repository at this point in the history