Introduce new errors for unsupported driver behaviors #1188
Conversation
jedevc
force-pushed
the
driver-opt-warnings
branch
from
c924769
to
67c75f9
Compare
jedevc
force-pushed
the
driver-opt-warnings
branch
from
67c75f9
to
0d2b165
Compare
jedevc
force-pushed
the
driver-opt-warnings
branch
from
0d2b165
to
50cf979
Compare
|
Have added another check, to error on attempting to edit nodes with |
There was a problem hiding this comment.
For the node update, if we are allowing flags then I don't see a reason why we would error on driveropt/config.
For the mixed drivers, looks like an oversight as well. Although this one is harder to fix. I don't see a specific reason why this should not be allowed. All the driver instances are passed separately to the build function. They do not need to be of the same type there.
I think at the very least we should warn here - we allow the Will update the PR to do this.
True. However, the way we store the drivers in config makes this harder to do - the driver is attached to the |
Signed-off-by: Justin Chadwell <me@jedevc.com>
This patch reorders+refactors the runCreate function to ensure that we can detect and notify the user in the scenario that the user attempts to combine multiple drivers in a single builder, which is an unsupported scenario. Previously, we would just overwrite the previous builder with the new driver, potentially invalidating the already existing nodes. Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
driver-opt-warnings
branch
2 times, most recently
from
99a0764
to
2653478
Compare
Previously, editing nodes to contain a new set of driver options or config files was unsupported, and silently dropping them. In this patch, we update with these, as well as add a new warning message that any new options may not taken into account until the builder restarts (which may apply to the flags, platforms and endpoints as well). Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
driver-opt-warnings
branch
from
2653478
to
ef0cbf2
Compare
Around discussion in #1186, a few issues with buildx drivers came up. These scenarios are unsupported, but the user isn't warned, for example:
Creating builders with the same name as context builders gives a warning, but appending and deleting doesn't.This PR should resolve the above issues, and provide a more helpful local debugging experience.