docker/install: Fix rootless install, make teardown also cleanup the toolDir #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
force-pushed
the
docker-install-rootless2
branch
from
9b34934 to
b4d6302
Compare
vvoland
changed the title
vvoland
force-pushed
the
docker-install-rootless2
branch
from
b4d6302 to
15ee71b
Compare
vvoland
changed the title
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
The `toolDir` is added to `PATH` on install, so make sure the binaries aren't accessible after a teardown. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
docker-install-rootless2
branch
from
15ee71b to
15a9f92
Compare
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failure observed in: docker/setup-docker-action#124