Skip to content

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Nov 6, 2024

Wire up rootless config to the new rootless Install option.

@crazy-max
Copy link
Member

@vvoland #125 has been merged

@vvoland vvoland force-pushed the rootless branch 2 times, most recently from 511bb41 to 8ba5d61 Compare November 8, 2024 09:18
@vvoland vvoland marked this pull request as ready for review November 8, 2024 09:37
@vvoland vvoland requested a review from crazy-max as a code owner November 8, 2024 09:37
@crazy-max
Copy link
Member

Pushed extra commit with a rootless job for ci and seems it fails: https://github.com/crazy-max/ghaction-setup-docker/actions/runs/11740833994/job/32708245277#step:3:45

image

@vvoland
Copy link
Contributor Author

vvoland commented Nov 8, 2024

Oh, I see. I forgot that rootlesskit is also in the rootless-extras. Wondering how did the integration test in actions-toolkit pass though? 🤔

EDIT: Oh, actually the downloaded binaries were added to PATH and it persisted over the multiple test cases, so it had the rootlesskit from the previous image install!

Fixing that up in: docker/actions-toolkit#486

@crazy-max
Copy link
Member

#126 has been merged if you want to rebase

Wire up `rootless` config to the new `rootless` Install option.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@crazy-max crazy-max merged commit 332d315 into docker:master Nov 14, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants