Add explicit JAVA_HOME environment variable #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # PLEASE DO NOT EDIT IT DIRECTLY. | ||
| # | ||
|
|
||
| FROM buildpack-deps:sid-scm |
There was a problem hiding this comment.
Managed to catch an amusing oversight here, too. 😄
…JAVA_HOME" values during build
…ny containers and invocations of "apt-get update"
|
Yay, finally 🍏. |
|
LGTM |
yosifkit
added a commit
that referenced
this pull request
Jan 5, 2016
Add explicit JAVA_HOME environment variable
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jan 7, 2016
- `docker`: alpine:3.3 (docker-library/docker#7) - `drupal`: 8.0.2 - `java`: explicit `JAVA_HOME` (docker-library/openjdk#61) - `php`: 5.5.31, 5.6.17, 7.0.2; fix edge case in `docker-php-ext-enable` (docker-library/php#172) - `postgres`: 9.5.0; set `PGDATA` perms to `0700` (docker-library/postgres#110) - `python`: add `alpine` variant for 3.5 (docker-library/python#74) - `rabbitmq`: fix SSL bugs (docker-library/rabbitmq#55, docker-library/rabbitmq#56) - `wordpress`: 4.4.1
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `docker`: alpine:3.3 (docker-library/docker#7) - `drupal`: 8.0.2 - `java`: explicit `JAVA_HOME` (docker-library/openjdk#61) - `php`: 5.5.31, 5.6.17, 7.0.2; fix edge case in `docker-php-ext-enable` (docker-library/php#172) - `postgres`: 9.5.0; set `PGDATA` perms to `0700` (docker-library/postgres#110) - `python`: add `alpine` variant for 3.5 (docker-library/python#74) - `rabbitmq`: fix SSL bugs (docker-library/rabbitmq#55, docker-library/rabbitmq#56) - `wordpress`: 4.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28 (commit carried/rebased here)
Fixes #27
For reference, the intended use-case of the "docker-java-home" script this installs is things like https://github.com/docker-library/tomcat/pull/19/files#diff-03f3e74233d756c542dc2d234fe3c43bR42, where we are
FROMthe JRE image, but install the JDK temporarily in order to compile something and then remove it again for size.