Skip to content

Issue #7: Add Tomcat Native Libraries #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ahromis
Copy link

@ahromis ahromis commented Nov 17, 2015

Seems to work for every version of Tomcat and JRE in this repo -- seeing output like this when Tomcat starts:

Nov 17, 2015 5:46:38 PM org.apache.catalina.core.AprLifecycleListener lifecycleEvent
INFO: Loaded APR based Apache Tomcat Native library 1.1.33 using APR version 1.5.1.
Nov 17, 2015 5:46:38 PM org.apache.catalina.core.AprLifecycleListener lifecycleEvent
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters [false], random [true].
Nov 17, 2015 5:46:38 PM org.apache.catalina.core.AprLifecycleListener initializeSSL
INFO: OpenSSL successfully initialized (OpenSSL 1.0.1k 8 Jan 2015)

@md5
Copy link
Contributor

md5 commented Nov 19, 2015

LGTM

The Travis failure looks like a hiccup from a Debian mirror. Perhaps @tianon, @yosifkit, or @Moghedrin can rerun that build from the Travis site.

@andyshinn
Copy link

Related to #18, the URLs should be updated to https://archive.apache.org/dist/tomcat/tomcat-$TOMCAT_MAJOR/v$TOMCAT_VERSION/bin/apache-tomcat-$TOMCAT_VERSION.tar.gz as the main URL only has the latest version.

I pushed a Tomcat 7 JRE 7 image to andyshinn/tomcat:7-jre7 if anyone wants to test. It appears to be working for me (an application load and the APR warning is gone). However, I haven't yet done any performance testing to validate if things are actually faster with APR or not.

@@ -34,5 +34,18 @@ RUN set -x \
&& rm bin/*.bat \
&& rm tomcat.tar.gz*

RUN set -x \
&& apt-get update \
&& apt-get install -yq gcc make openssl libssl-dev libapr1 libapr1-dev openjdk-7-jdk="$JAVA_DEBIAN_VERSION" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort the list and put it in a variable so it is easier to purge later? It should make it more obvious that libapr1 is not a build dependency, but a run dependency. Redis has a pretty similar example: https://github.com/docker-library/redis/blob/98a586a0f5c505e120b22dc94efc1fa5c492ce35/3.0/Dockerfile#L24-L36. You should also drop openssl since it is already in the java base image since it has curl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants