Skip to content

Edits and revisions to read-me's content. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Edits and revisions to read-me's content. #12

wants to merge 2 commits into from

Conversation

fredlf
Copy link

@fredlf fredlf commented Sep 11, 2014

No description provided.

@yosifkit
Copy link
Member

My only issue is that we may not want to line wrap the short description. It is not markdown and every character is important (hard limit of 200).

@yosifkit
Copy link
Member

Ok, I tested a line wrap on the short description on the docker hub and it shows up on the hub page but not on search results.

@yosifkit yosifkit closed this Sep 12, 2014
@yosifkit yosifkit reopened this Sep 12, 2014
@fredlf
Copy link
Author

fredlf commented Sep 12, 2014

So should I keep wrapping them or no? I'm fine either way.

@yosifkit
Copy link
Member

If the hub changes to ignore them, then it should be fine.

@tianon?

@tianon
Copy link
Member

tianon commented Sep 13, 2014

Yeah, I'm -1 on wrapping the -short.txt files. They aren't markdown, and thus line breaks are significant. Don't worry about updating all these PRs though - I'm going through and stealing the content from each of them by hand both to get a second set of eyes on the formatting (I've already caught one mistake we made before you ever got your hands on them) and to reflow them to 80 columns (since it looks like your editor is actually configured at ~90 columns), and also because several of them can't merge thanks to updates to the base README.md files. I'll have a PR with all of the updates (especially the reflowing) shortly-ish (definitely before EOD today).

@yosifkit yosifkit closed this in #22 Sep 15, 2014
ypid pushed a commit to ypid/docker-docs that referenced this pull request Nov 1, 2015
Add ToC in all role documentation files
ypid pushed a commit to ypid/docker-docs that referenced this pull request Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants