Skip to content

Reflow all the language stack README-content.md files to 80 columns and incorporate Fred's changes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2014

Conversation

tianon
Copy link
Member

@tianon tianon commented Sep 13, 2014

This also includes Fred's updates to the README-short.txt files, and a bunch of very minor changes for consistency (using "PHP" instead of "php", ending sentences that describe and lead into a code block with a ":", using "Go" instead of "Golang" and "Hy" instead of "Hylang" within prose, not using periods at the end of headlines, etc).

A really fun one included here is that Java mentioned both using GNU Make inside the container (and java doesn't include make presently), and some of the prose mentioned go build after we ran javac, which was extra neat.

I've also reflowed the footer here, since it looks like Fred's got his reflow set at 90 columns, not 80 (which is half the reason I made this PR, the other half being that I wanted to go over them all one more time myself to fix more minor inconsistencies).

cc @fredlf (would you mind taking one last gander over these to make sure I haven't missed anything that sticks out to you on a last read-over?)

Closes #7
Closes #8
Closes #12
Closes #13
Closes #14
Closes #15
Closes #16
Closes #17
Closes #18
Closes #19
Closes #20
Closes #21

(To make reviewing this simple, I haven't run ./update.sh yet - once it's been reviewed and we're all happy with it and thus have merged it, I'll run ./update.sh to update all the README.md files too.)

… and incorporate Fred's changes

This also includes Fred's updates to the `README-short.txt` files, and a bunch of very minor changes for consistency (using "PHP" instead of "php", ending sentences that describe and lead into a code block with a ":", using "Go" instead of "Golang" and "Hy" instead of "Hylang" within prose, not using periods at the end of headlines, etc).

A really fun one included here is that Java mentioned both using GNU Make inside the container (and `java` doesn't include `make` presently), and some of the prose mentioned `go build` after we ran `javac`, which was extra neat.
@yosifkit
Copy link
Member

LGTM

yosifkit added a commit that referenced this pull request Sep 15, 2014
Reflow all the language stack `README-content.md` files to 80 columns and incorporate Fred's changes
@yosifkit yosifkit merged commit 40813bd into docker-library:master Sep 15, 2014
@yosifkit yosifkit deleted the consistency-and-fredlf branch September 15, 2014 16:40
@fredlf
Copy link

fredlf commented Sep 15, 2014

Thumbs up from me. Sorry about re-flow error. BBE changed my prefs without telling me!

ypid pushed a commit to ypid/docker-docs that referenced this pull request Nov 1, 2015
ypid pushed a commit to ypid/docker-docs that referenced this pull request Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants