Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new apt-get dist-clean command #154

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

tianon
Copy link
Member

@tianon tianon commented Jan 12, 2024

APT 2.7.8 has a new apt-get dist-clean command designed exactly for our use case of "remove APT lists" and it's much better than our hammer. 🎉

@tianon
Copy link
Member Author

tianon commented Jan 12, 2024

(This is the follow-up I teased in #153, and the reason I was looking at the files in the first place to do that cleanup 😂)

"bullseye",
"buster",

"noble", # TODO once 2.7.8+ makes it into devel (and images are rebuilt), this should be removed!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://launchpad.net/ubuntu/noble/+source/apt 👀

(APT 2.7.9 is in proposed now, so hopefully will be in the next ubuntu:noble image update 💪)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not docker-library/official-images#16059, but will hold out hope for the next one (it's still in proposed so this isn't unexpected) 👍

APT [2.7.8](https://tracker.debian.org/news/1492892/accepted-apt-278-source-into-unstable/) has a new `apt-get dist-clean` command designed exactly for our use case of "remove APT lists" and it's much better than our hammer. 🎉
@tianon
Copy link
Member Author

tianon commented Jan 12, 2024

(updated shared.jq with some helpful links for determining the appropriate set in the future 👍)

Copy link

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


# https://tracker.debian.org/pkg/apt
# https://packages.debian.org/apt
"trixie", # TODO once 2.7.8 migrates to testing (and images are rebuilt), this should be removed!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.debian.org/news/1495149/apt-279-migrated-to-testing/ 👀

(The next rebuild of Debian can come with a removal of this line 💪)

@tianon tianon merged commit 803a857 into docker-library:master Jan 16, 2024
12 checks passed
@tianon tianon deleted the apt-get-dist-clean branch January 16, 2024 18:22
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jan 16, 2024
Changes:

- docker-library/buildpack-deps@803a857: Merge pull request docker-library/buildpack-deps#154 from infosiftr/apt-get-dist-clean
- docker-library/buildpack-deps@2b3a8b7: Switch to new `apt-get dist-clean` command
- docker-library/buildpack-deps@bea86ea: Merge pull request docker-library/buildpack-deps#153 from infosiftr/cleanup
- docker-library/buildpack-deps@d0ecd4b: Cleanup comments and remove unnecessary conditional
- docker-library/buildpack-deps@c6324a9: Update GHA YAML with bashbrew example improvements (esp. concurrency:)
martin-g pushed a commit to martin-g/docker-official-images that referenced this pull request Apr 3, 2024
Changes:

- docker-library/buildpack-deps@803a857: Merge pull request docker-library/buildpack-deps#154 from infosiftr/apt-get-dist-clean
- docker-library/buildpack-deps@2b3a8b7: Switch to new `apt-get dist-clean` command
- docker-library/buildpack-deps@bea86ea: Merge pull request docker-library/buildpack-deps#153 from infosiftr/cleanup
- docker-library/buildpack-deps@d0ecd4b: Cleanup comments and remove unnecessary conditional
- docker-library/buildpack-deps@c6324a9: Update GHA YAML with bashbrew example improvements (esp. concurrency:)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants