Cleanup comments and remove unnecessary conditional #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, switch to using `set -eux` + `;` chains consistently (no more `&&`).
LaurentGoderre
approved these changes
Jan 9, 2024
yosifkit
approved these changes
Jan 9, 2024
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 9, 2024
Changes: - docker-library/buildpack-deps@bea86ea: Merge pull request docker-library/buildpack-deps#153 from infosiftr/cleanup - docker-library/buildpack-deps@d0ecd4b: Cleanup comments and remove unnecessary conditional - docker-library/buildpack-deps@c6324a9: Update GHA YAML with bashbrew example improvements (esp. concurrency:)
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 16, 2024
Changes: - docker-library/buildpack-deps@803a857: Merge pull request docker-library/buildpack-deps#154 from infosiftr/apt-get-dist-clean - docker-library/buildpack-deps@2b3a8b7: Switch to new `apt-get dist-clean` command - docker-library/buildpack-deps@bea86ea: Merge pull request docker-library/buildpack-deps#153 from infosiftr/cleanup - docker-library/buildpack-deps@d0ecd4b: Cleanup comments and remove unnecessary conditional - docker-library/buildpack-deps@c6324a9: Update GHA YAML with bashbrew example improvements (esp. concurrency:)
martin-g
pushed a commit
to martin-g/docker-official-images
that referenced
this pull request
Apr 3, 2024
Changes: - docker-library/buildpack-deps@803a857: Merge pull request docker-library/buildpack-deps#154 from infosiftr/apt-get-dist-clean - docker-library/buildpack-deps@2b3a8b7: Switch to new `apt-get dist-clean` command - docker-library/buildpack-deps@bea86ea: Merge pull request docker-library/buildpack-deps#153 from infosiftr/cleanup - docker-library/buildpack-deps@d0ecd4b: Cleanup comments and remove unnecessary conditional - docker-library/buildpack-deps@c6324a9: Update GHA YAML with bashbrew example improvements (esp. concurrency:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, switch to using
set -eux+;chains consistently (no more&&).(I have a planned follow-up to this for which https://tracker.debian.org/news/1492892/accepted-apt-278-source-into-unstable/ is a spoiler, but I need a new
debianrebuilt with APT 2.7.8 in it before I can send that one. 😅)