Skip to content

fix: Ensure syntax highlighting after expanding tool output (#32) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnouri merged 1 commit into from
Jan 7, 2026
Merged

fix: Ensure syntax highlighting after expanding tool output (#32) #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pi-coding-agent.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,6 +1227,8 @@ Shows preview lines with expandable toggle for long output."
(if expanded
(pi-coding-agent--insert-collapsed-content preview-content full-content lang hidden-count)
(pi-coding-agent--insert-expanded-content preview-content full-content lang hidden-count))
;; Ensure fontification of inserted content (JIT font-lock is lazy)
(font-lock-ensure content-start (point))
;; Update overlay to include new content (overlay no longer has rear-advance)
(move-overlay ov (car bounds) (point)))))))

Expand Down
29 changes: 29 additions & 0 deletions test/pi-coding-agent-test.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,6 +1388,35 @@ which is just a success message."
(should (string-match-p "\\.\\.\\..*more lines" (buffer-string)))
(should-not (string-match-p "L10" (buffer-string)))))

(ert-deftest pi-coding-agent-test-tool-toggle-expands-with-highlighting ()
"Expanded tool output has syntax highlighting applied.
Regression test for issue #32: JIT font-lock doesn't fontify expanded content."
(with-temp-buffer
(pi-coding-agent-chat-mode)
;; Create a read tool with Python content (>10 lines to trigger collapse)
;; The 'def' keyword is on line 11, hidden initially
(pi-coding-agent--display-tool-start "read" '(:path "test.py"))
(pi-coding-agent--display-tool-end "read" '(:path "test.py")
'((:type "text" :text "line1\nline2\nline3\nline4\nline5\nline6\nline7\nline8\nline9\nline10\ndef hello():\n return 42"))
nil nil)
;; Initially collapsed - 'def' is hidden
(should (string-match-p "\\.\\.\\..*more lines" (buffer-string)))
(should-not (string-match-p "def hello" (buffer-string)))
;; Expand
(goto-char (point-min))
(search-forward "..." nil t)
(backward-char 1)
(pi-coding-agent-toggle-tool-section)
;; Now 'def' should be visible
(should (string-match-p "def hello" (buffer-string)))
;; Find 'def' keyword and check for syntax highlighting
(goto-char (point-min))
(search-forward "def" nil t)
(let ((face (get-text-property (match-beginning 0) 'face)))
;; Should have font-lock-keyword-face from python-mode
(should (or (eq face 'font-lock-keyword-face)
(and (listp face) (memq 'font-lock-keyword-face face)))))))

(ert-deftest pi-coding-agent-test-tab-works-from-anywhere-in-block ()
"TAB toggles tool output from any position within the block."
(with-temp-buffer
Expand Down