fix: Ensure syntax highlighting after expanding tool output (#32)#39
Merged
fix: Ensure syntax highlighting after expanding tool output (#32)#39
Conversation
Add font-lock-ensure call after toggling tool output. JIT font-lock only fontifies visible portions lazily, so expanding collapsed content left it unhighlighted until the user scrolled around. The fix follows the established pattern from --finalize-streaming-message and --render-history-text which both call font-lock-ensure after inserting content.
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
Add font-lock-ensure call after toggling tool output. JIT font-lock only fontifies visible portions lazily, so expanding collapsed content left it unhighlighted until the user scrolled around. The fix follows the established pattern from --finalize-streaming-message and --render-history-text which both call font-lock-ensure after inserting content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix syntax highlighting lost when expanding collapsed tool output.
Problem
When expanding collapsed tool output (clicking
... (N more lines)), syntax highlighting was missing. It would appear erratically "bit by bit" when scrolling around because JIT font-lock only fontifies visible portions lazily.Root Cause
--toggle-tool-outputcalls--insert-expanded-contentwhich inserts markdown code fences but never callsfont-lock-ensure.Compare with:
--finalize-streaming-message(line 1064) - callsfont-lock-ensure✓--render-history-text(line 1831) - callsfont-lock-ensure✓Fix
Add
font-lock-ensurecall after inserting expanded/collapsed content in--toggle-tool-output:Test Added
pi-coding-agent-test-tool-toggle-expands-with-highlighting- verifies that after expanding, Python keywords havefont-lock-keyword-face.Closes #32