Draft
Conversation
guillaumeboehm
force-pushed
the
feature-cli
branch
from
ac3f86e to
5fae4cd
Compare
guillaumeboehm
force-pushed
the
feature-cli
branch
from
5fae4cd to
6648097
Compare
- Only the CoolerBoost for now as a POC - Modified some lines that static analyzer was complaining about - Add Options class to handle arg parsing and different option values
Less performant but more readable
guillaumeboehm
force-pushed
the
feature-cli
branch
from
6648097 to
e857eb1
Compare
This reverts commit 4dc6f55.
Collaborator
|
I can't help but wonder, why not write directly to the sysfs files exposed by msi-ec? |
Author
Well I could, but I figured it wouldn't be too much effort to expand mcontrolcenter with cli support for less savy people. |
Collaborator
can't blame you for that, hopefully with msi-wmi-platform module things would become less complicated (also for scripting) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CLI Object and options parsing.
The window "show" behavior is changed from "newConnection" to a socket message.
If CLI options are given to the program, the program will not show the window and only execute the commands. If a mcontrolcenter server exists a socket message is then sent to refresh the window data.
This is a POC with the CoolerBoost toggle only. I will implement the rest after a first review.