Skip to content

Add user mode CLI command#2

Merged
guillaumeboehm merged 5 commits intoguillaumeboehm:mainfrom
Dexter2038:main
Aug 15, 2025
Merged

Add user mode CLI command#2
guillaumeboehm merged 5 commits intoguillaumeboehm:mainfrom
Dexter2038:main

Conversation

@Dexter2038
Copy link

I needed it, so I added it.

Tested, everything is working.

image

@guillaumeboehm
Copy link
Owner

Hey! Thanks for the PR, sorry it took me so long to come back to it, do you mind rebasing on the latest main? If you don't use this anymore tell me so I'll take care of it myself ;)

@Dexter2038
Copy link
Author

Dexter2038 commented Aug 15, 2025

Thanks for getting back to me! I’m happy to rebase my branch since I’m still using my modified version of the app.

@Dexter2038
Copy link
Author

250815_14h21m48s_screenshot Changed some commits' names and authorship, fixed conflicts and fixed some errors. Pinned screenshot of successfully running program. It builds, it works. At least on my machine. Waiting to finally merge

Copy link
Owner

@guillaumeboehm guillaumeboehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, just a tiny improvement and we're good

@Dexter2038
Copy link
Author

Dexter2038 commented Aug 15, 2025

Added print on failed EC data update

@Dexter2038 Dexter2038 changed the title user mode CLI command has been added Add user mode CLI command Aug 15, 2025
@Dexter2038
Copy link
Author

Should I change "user mode" to "User Mode" for consistency? The code prints "Cooler Boost" and not "cooler boost", so I guess it would be better if naming would be the same, right?

@Dexter2038
Copy link
Author

I did change it.

@guillaumeboehm
Copy link
Owner

Should I change "user mode" to "User Mode" for consistency? The code prints "Cooler Boost" and not "cooler boost", so I guess it would be better if naming would be the same, right?

Eh it was fine but ok ^^

@guillaumeboehm guillaumeboehm merged commit e4c13c8 into guillaumeboehm:main Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants