Restore accidentally removed import from std.math

[Geod24]

It was removed in PR7473: #7473 (comment)
It caused a two-days-long outage of Buildkite: dlang/ci#418 (comment)

[dlang-bot]

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7483"

[MoonlightSentinel]

Well, that is a private import ... that shouldn't be visible when importing std.math (?)

[Geod24]

It's a bug, selective imports create an alias. Some say it's a feature...

[Geod24]

My bad, the bug seems to have been fixed, but it was public anyway (L543). The import was on line 684.

[MoonlightSentinel]

Thanks, did not see that public:.

Should this already deprecate the import?

[Geod24]

Should this already deprecate the import?

I think it should be deprecated, but I have no interest in deprecating that import myself.

I'm only raising this PR because the original reviewer 1) ignored the CI and 2) didn't act when the error started to creep up everywhere. If this import is to be deprecated, it should be by someone that has interest in spending the time to do it, not the person fixing someone else's careless mistake.

And IMO this reasoning stands regardless of the amount of work required. Deprecating an import might be just a few minutes of time, but it's a few minutes more than I was willing to spend on Phobos when I started to work on my own stuff. This is also why I prefer to outright revert stuff than attempt to fix the mistake, as you've seen recently.

We could call this the bug asymmetry principle, if you will.

[MoonlightSentinel]

Fair enough

[dnadlinger]

Apparently the DAutoTest result upload failed… Is there a better way these days than just to empty-amend the branch?

[wilzbach]

Nope unfortunately not, but in this case the force-merge option can be used to save some time.

[ibuclaw]

@Geod24 - we're blocked by you. dlang/dmd#10534