Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std.math: Remove deprecated creal functions #7473

Merged
merged 1 commit into from
May 13, 2020
Merged

std.math: Remove deprecated creal functions #7473

merged 1 commit into from
May 13, 2020

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 9, 2020

First deprecation was in Jan 2018.

Unittests have been copied across to std.complex where appropirate.

@ibuclaw ibuclaw added the math label May 9, 2020
@ibuclaw ibuclaw requested a review from wilzbach May 9, 2020 16:39
@ibuclaw ibuclaw requested a review from kyllingstad as a code owner May 9, 2020 16:39
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7473"

@ibuclaw ibuclaw mentioned this pull request May 9, 2020
Merged
@ibuclaw
Copy link
Member Author

ibuclaw commented May 9, 2020

Depends on dlang/dmd#11123

@ibuclaw ibuclaw force-pushed the stdmath/creal branch 2 times, most recently from cf32d1a to 5b37295 Compare May 10, 2020 15:23
@ibuclaw
Copy link
Member Author

ibuclaw commented May 11, 2020 

../dmd/src/dmd/doc.d(368,34): Error: file `"default_ddoc_theme.ddoc"` cannot be found or not in a path specified with `-J`
.generated/stable_dmd-2.088.0/dmd2/linux/bin64/dmd failed with exit code 1.
posix.mak:928: recipe for target '.generated/ddoc_preprocessor' failed

Did someone in the dmd repo break the ddoc build?

@ibuclaw ibuclaw force-pushed the stdmath/creal branch 2 times, most recently from d0c4a3b to b1ee26f Compare May 13, 2020 17:20
@ibuclaw
std.math: Remove deprecated creal functions
c71bd19 
First deprecation was in Jan 2018.

Unittests have been copied across to std.complex where appropirate.
@ibuclaw
Copy link
Member Author

ibuclaw commented May 13, 2020

Freebsd/32 is green, so knock wood the rest should follow...

@thewilsonator
Copy link
Contributor

Buildkite looks unrelated.

@thewilsonator thewilsonator merged commit 26c971a into dlang:master May 13, 2020
@ibuclaw ibuclaw deleted the stdmath/creal branch May 13, 2020 19:42
Geod24
Geod24 reviewed May 15, 2020
View reviewed changes
std/math.d
}}
}

import std.meta : AliasSeq;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed ? It's a breaking change.

Copy link
Member

@dnadlinger dnadlinger May 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having flashbacks here – didn't we fix selective imports to be private a few years ago (i.e. the infamous "bug 314")? Edit: Ah, there are public:s in some random places all over that (multi-kloc) file. In case anyone ever wondered why that is a bad idea…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @dnadlinger said, did not anticipate there being a public: being in effect here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.dlang.org/show_bug.cgi?id=20836

This was referenced May 15, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadlinger dnadlinger dnadlinger left review comments

@Geod24 Geod24 Geod24 left review comments

@wilzbach wilzbach wilzbach approved these changes

@thewilsonator thewilsonator thewilsonator approved these changes

@kyllingstad kyllingstad Awaiting requested review from kyllingstad

Assignees
No one assigned
Labels
math Merge:auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ibuclaw @dlang-bot @thewilsonator @dnadlinger @Geod24 @wilzbach