Skip to content

Fix broken ddoc #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Fix broken ddoc #5526

merged 1 commit into from
Jun 30, 2017

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Jun 29, 2017

Follow-up to #5523 (let's automate this)

dlang.org PR (for the automated check): dlang/dlang.org#1782

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Member Author

wilzbach commented Jun 29, 2017

(also contains the HTTP fix from #5516 as this is detected by the new check as well)

@quickfur
Copy link
Member

LGTM

@dlang-bot dlang-bot merged commit 5eec0d0 into dlang:master Jun 30, 2017
@wilzbach wilzbach deleted the fix-ddoc3 branch June 30, 2017 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants