std.net.curl: RFC link at HTTP client docs is broken

[zaydek-old]

Please update link so it's clickable

[dlang-bot]

Thanks for your pull request, @zaydek! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

• smaller, focused PRs are easier to review than big ones

• try not to mix up refactoring or style changes with bug fixes or feature enhancements

• provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

[CyberShadow]

Fixed that for you!

[wilzbach]

continuous-integration/jenkins/pr-merge — This commit cannot be built

Hmm ...

Btw, while not intended as a proper solution, the Dlang-Bot might soon understand commands like:

• please squash this PR ("bot-squash")
• please rebase this PR ("bot-rebase")

Especially the later is unfortunately currently commonly needed on PRs.

[wilzbach]

(rebased to rekick Jenkins and used this opportunity to rebase the PR to stable and squash the commits, i.e. drop the comment).

[wilzbach]

Rebased again. @CyberShadow imho either @MartinNowak agrees to temporarily disable DUB + Vibe.d tests or we set disable set the Jenkins project-tester to non required again. It's not really fun to rebase a PR 3-4 times just to get it to pass at the project-tester ....

[wilzbach]

imho either @MartinNowak agrees to temporarily disable DUB + Vibe.d tests or we set disable set the Jenkins project-tester to non required again. It's not really fun to rebase a PR 3-4 times just to get it to pass at the project-tester ....

CC @CyberShadow

Also it seems that there's something wrong with the auto-tester - it doesn't detect this PR (it's not even listed).

[CyberShadow]

Could you email Martin and CC me? I think we need to do something about this today, but Martin isn't responsive to GitHub mentions.

[wilzbach]

Could you email Martin and CC me? I think we need to do something about this today, but Martin isn't responsive to GitHub mentions.

Done.

[wilzbach]

Also it seems that there's something wrong with the auto-tester - it doesn't detect this PR (it's not even listed).

Ping @CyberShadow @braddr - should we simply create a new PR?

[wilzbach]

This has been superseded by #5526

@zaydek thanks again for submitting this fix. I hope you weren't that frustrated by our temporary CI problems. We are looking forward to your next contribution ;-)

[braddr]

I don't see anything in the auto-tester logs to point to something going wrong, other than the lack of any attempts to build this pull request. I see the record of it's existence and the edits to switch branches, update the head commit a few times, and add the merge label. But no builds happened. Next time you see this happen, let me know and I'll dig deeper.