This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix DMD path to ../generated #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
This was referenced Nov 28, 2017
|
The Win_32_64 build failed with: which doesn't make sense to me. On the other hand, the phobos build went without a hitch, so the problem may go away. |
That's usually the error message that appears when patching the makefiles by the autotester fails. @braddr, please remove that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm trying to move ahead with the ddmd -> dmd transition (dlang/dmd#7135) and due to braddr/at-client#4 we are stuck at the moment.
Hence, this PR tries to set the
DMDbinary path by default to one in thegenerateddirectory. As I have no Windows machine, I'm doing this more or less blindly, but it looks trivial enough.See also: dlang/phobos#5892