ddmd -> dmd transition #7135

wilzbach · 2017-09-14T00:20:30Z

Let's see what the missing bits on Windows are.
CC @RazvanN7

Required steps

dlang-bot · 2017-09-14T00:20:31Z

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

JinShil · 2017-09-14T00:25:03Z

If this is to investigate better naming for the compiler-as-a-library API, would it be better to just use the name d in an effort to make it compiler-agnostic?

wilzbach · 2017-09-14T00:30:55Z

If this is to investigate better naming for the compiler-as-a-library API, would it be better to just use the name d in an effort to make it compiler-agnostic?

Yes and no. tl;dr: it's picking up an effort to clean up the folder hierarchy started by @RazvanN7 and @andralex half a year ago (ddmd comes back from the old days when it meant "D version of dmd").
See also:

#6489
#6562
#6595

JinShil · 2017-09-14T01:04:57Z

(ddmd comes back from the old days when it meant "D version of dmd").

Yes, I'm aware of that, but I was questioning the use of dmd as a package name as it is specific to only one brand of D compiler. My suggestion was to use the name d instead.

wilzbach · 2017-09-14T01:12:59Z

Yes, I'm aware of that, but I was questioning the use of dmd as a package name as it is specific to only one brand of D compiler. My suggestion was to use the name d instead.

While I appreciate your input, there have been many lengthy discussions about this and a decision has been made to rename to "dmd":

#6489 (comment)
#6489 (comment)
#6489 (comment)

Unfortunately the rename was left in stage 2 and I am just trying to take it to the finish line, which sadly is though enough. Also, there are (and hopefully will be) other D compilers which aren't based on the DMD frontend (e.g. SDC), so taking the d namespace would be quite unfriendly (especially if lazy people used d to organize their private packages).

@CyberShadow regarding:

.generated/stable_dmd-2.072.2/dmd2/linux/bin64/rdmd --compiler=.generated/stable_dmd-2.072.2/dmd2/linux/bin64/dmd -conf=.generated/stable_dmd-2.072.2/dmd2/linux/bin64/dmd.conf modlist.d ../druntime ../phobos ../dmd --ex=gc. --ex=rt. --ex=core.internal. --ex=core.stdc.config --ex=core.sys. --ex=std.algorithm.internal --ex=std.c. --ex=std.concurrencybase --ex=std.internal. --ex=std.regex.internal. --ex=std.windows.iunknown --ex=std.windows.registry --ex=etc.linux.memoryerror --ex=std.experimental.ndslice.internal --ex=std.stdiobase --ex=std.typetuple --ex=tk. --ex=msvc_dmc --ex=msvc_lib --ex=ddmd.libmach --ex=ddmd.libmscoff --ex=ddmd.objc_glue --ex=ddmd.scanmach --ex=ddmd.scanmscoff \
	--dump object --dump std --dump etc --dump core --dump ddmd >.generated/modlist-prerelease.ddoc
core.exception.AssertError@modlist.d(75): ddmd can't be found.
----------------

(this is about the menu generation for the dlang.org (Ddoc version))
Q: Would you be okay with making this error soft-failing for the time being?

CyberShadow · 2017-09-14T03:12:32Z

Q: Would you be okay with making this error soft-failing for the time being?

You're asking the wrong person, DMD docs on dlang.org are mostly pushed by W/A. But I suggest finding a way to do things that doesn't imply that "just break it for now, we'll fix it later", as "later" may be postponed more than expected.

Why not detect the name of the DMD package/directory?

ibuclaw · 2017-09-15T06:55:57Z

I'd still prefer some agnostic name as per comment I made many months ago in linked pr above.

andralex · 2017-09-15T14:16:03Z

I'd still prefer some agnostic name as per comment I made many months ago in linked pr above.

It's a nice point but gets us into rebranding the front end. I'd say we move forward with this obvious step and defer that.

andralex · 2017-09-15T14:16:38Z

Let's do this already. @MartinNowak ? @WalterBright ?

MartinNowak

Anytime

ibuclaw · 2017-09-23T20:02:25Z

Just fix the build.

wilzbach · 2017-10-05T23:53:56Z

Seems like we need to update the auto-tester again: https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=2816476&dataid=19934733&isPull=true :/

-> braddr/at-client#4

At least CircleCi and Jenkins have been green.

andralex · 2017-10-05T23:54:38Z

rebase?

andralex · 2017-10-05T23:55:30Z

Let's boldly go see regressions we haven't seen before :).

wilzbach · 2017-10-05T23:58:19Z

rebase?

I really appreciate the enthusiasm, but we have to wait at least for dlang/dlang.org#1903 and braddr/at-client#4 (no point in constantly rebasing until then).
This turns out to be much more pain than initially thought :/

andralex · 2017-10-05T23:59:12Z

Let's hope gain will follow the pain. Thanks for the hard work! (Also please hop on slack.)

wilzbach · 2017-12-13T10:28:04Z

ping @braddr - this is waiting for you please pull braddr/at-client#5 thx!
I've updated a couple machines with these changes. Assuming they survive without problems I'll finish deploying to the fleet tomorrow or thursday.

Thanks a lot for pulling this @braddr 🎉 🎂

@ other: FYI I just rebased this PR and it's looking good so far. There were some changes on dlang.org, so we have to update this again (-> dlang/dlang.org#1971), but apart from that, this PR is ready and waiting for the other auto-tester machines to be updated :)

wilzbach · 2017-12-14T07:59:59Z

Alrighty - this is passing on all auto-tester machines now:

According to @braddr

Changes are deployed to most machines. The ones left I can't access remotely, so will be at least another day before they're updated.

This means in a very foreseeable future we can finally move on with this.
Any last-minute or final thoughts?

This branch has conflicts that must be resolved

Don't get confused by this. The current stream of merged PRs into dmd is just too high to be able to constantly rebase this. Note that every merge PR will arise a conflict and as soon as we merge this here, all open PRs will have to be rebased once. This is fairly trivial though as git can handle renames quite well.

andralex · 2017-12-14T16:15:39Z

Can't wait!!

wilzbach · 2017-12-15T01:07:13Z

Can't wait!!

It looks really good. There are just a few hosts which haven't run these changes yet:

bellevue.puremagic.com (sets DMD for Druntime properly to /home/braddr/sandbox/at-client/master-132655-FreeBSD_32/dmd/generated/freebsd/release/32/dmd)
mac-vm-1.local (Last Heard From: 2017-12-13)
work-vm-1 (Last Heard From: 2017-12-13)

And there seem to be two other other hosts in the list which are solely used to the new FreeBSD OS changes:

ip-172-31-43-66 (idle, FreeBSD project)
ip-172-31-46-60 (idle, FreeBSD project)

But let's better wait for @braddr to give his okay.

sed -i "s/ddmd/dmd/g" -i **/*.[cdh]

sed -i "s/ddmd/dmd/g" -i **/*.sdl sed -i "s/ddmd/dmd/g" -i **/*.mak sed -i "s/ddmd/dmd/g" -i **/*.visualdproj sed -i "s/ddmd/dmd/g" -i **/*.vcxproj sed -i "s/ddmd/dmd/g" -i **/*.filters sed -i "s/ddmd/dmd/g" -i CODEOWNERS

wilzbach · 2017-12-15T02:36:09Z

But let's better wait for @braddr to give his okay.
All the machines are updated now.

Wohoo 🎉 🎈 🎂

Awesome. Thank you so much!
Everyone ready?

wilzbach · 2017-12-15T02:45:06Z

I just saw @klickverbot's comment from January this year:

The actual file-level reorganisation is something all of us can do given 20 minutes and a sed implementation of choice (well, okay, maybe an extra 10 to fix up the Windows makefiles).

...

andralex · 2017-12-15T04:50:10Z

So should I force merge this?

wilzbach · 2017-12-15T04:57:59Z

So should I force merge this?

Yes, please. Jenkins is failing due to it running out of space (CC @MartinNowak) and Travis seems to have hit a runnable/test17868b which appears to be a spurious failure (after all, it passed a couple of hours ago).

andralex · 2017-12-15T05:01:27Z

alrighty then

andralex · 2017-12-15T05:01:44Z

no mercy

RazvanN7 · 2017-12-15T10:52:39Z

Awesome. Thanks!

MartinNowak · 2017-12-16T15:54:04Z

Nice, a bit unfriendly to merge this just on the beta branch day.
https://forum.dlang.org/post/oknjtm$1unb$1@digitalmars.com

andralex · 2017-12-16T22:14:05Z

@MartinNowak sorry, lmk how I can help make things better

wilzbach · 2017-12-16T22:25:06Z

Same here! Did you ran into any issues already?
Sorry Martin. I lost totally track of the branching day.

dlang-bot added the Review:WIP Work In Progress - not ready for review or pulling label Sep 14, 2017

wilzbach added the in progress label Sep 14, 2017

wilzbach force-pushed the ddmd_dmd_transition branch from 7fd1ebe to 2a51fcd Compare September 14, 2017 00:38

wilzbach mentioned this pull request Sep 14, 2017

Preprare Jenkins for the final phase of the ddmd transition dlang/ci#68

Merged

wilzbach force-pushed the ddmd_dmd_transition branch from 2a51fcd to c317e74 Compare September 14, 2017 00:46

MartinNowak approved these changes Sep 23, 2017

View reviewed changes

wilzbach force-pushed the ddmd_dmd_transition branch from c317e74 to 126fc85 Compare October 5, 2017 23:07

wilzbach mentioned this pull request Oct 5, 2017

Prepare dlang.org for the ddmd -> dmd transition dlang/dlang.org#1903

Merged

wilzbach force-pushed the ddmd_dmd_transition branch from 126fc85 to e199efe Compare October 5, 2017 23:23

wilzbach mentioned this pull request Oct 5, 2017

Remove hard-coded src/dmd executables braddr/at-client#4

Merged

andralex approved these changes Oct 5, 2017

View reviewed changes

andralex added the Merge:auto-merge label Oct 5, 2017

wilzbach removed the Merge:auto-merge label Oct 5, 2017

JinShil removed the in progress label Nov 26, 2017

wilzbach mentioned this pull request Nov 28, 2017

Fix DMD path to ../generated dlang/druntime#1978

Merged

wilzbach force-pushed the ddmd_dmd_transition branch from 8552ed4 to 8dedc6b Compare December 13, 2017 23:49

wilzbach changed the title ~~[WIP] ddmd -> dmd transition~~ ddmd -> dmd transition Dec 14, 2017

wilzbach removed the Review:WIP Work In Progress - not ready for review or pulling label Dec 14, 2017

wilzbach force-pushed the ddmd_dmd_transition branch 2 times, most recently from 4291752 to 7396f68 Compare December 14, 2017 05:59

wilzbach force-pushed the ddmd_dmd_transition branch from 7396f68 to d937ba7 Compare December 14, 2017 10:32

wilzbach force-pushed the ddmd_dmd_transition branch 2 times, most recently from 8df0f47 to cd3ca68 Compare December 15, 2017 02:27

wilzbach added 3 commits December 15, 2017 03:29

Rename ddmd -> dmd

bc6f0b7

sed -i "s/ddmd/dmd/g" -i **/*.[cdh]

Rename ddmd text occurrences

ed9a730

sed -i "s/ddmd/dmd/g" -i **/*.sdl sed -i "s/ddmd/dmd/g" -i **/*.mak sed -i "s/ddmd/dmd/g" -i **/*.visualdproj sed -i "s/ddmd/dmd/g" -i **/*.vcxproj sed -i "s/ddmd/dmd/g" -i **/*.filters sed -i "s/ddmd/dmd/g" -i CODEOWNERS

Start fixing the CIs

cee698b

wilzbach force-pushed the ddmd_dmd_transition branch from cd3ca68 to cee698b Compare December 15, 2017 02:29

JinShil approved these changes Dec 15, 2017

View reviewed changes

wilzbach added the Merge:auto-merge label Dec 15, 2017

andralex merged commit a2697c4 into dlang:master Dec 15, 2017

wilzbach deleted the ddmd_dmd_transition branch December 15, 2017 05:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddmd -> dmd transition #7135

ddmd -> dmd transition #7135

wilzbach commented Sep 14, 2017 •

edited

Loading

dlang-bot commented Sep 14, 2017

JinShil commented Sep 14, 2017

wilzbach commented Sep 14, 2017

JinShil commented Sep 14, 2017 •

edited

Loading

wilzbach commented Sep 14, 2017

CyberShadow commented Sep 14, 2017

ibuclaw commented Sep 15, 2017

andralex commented Sep 15, 2017

andralex commented Sep 15, 2017

MartinNowak left a comment

ibuclaw commented Sep 23, 2017

wilzbach commented Oct 5, 2017

andralex commented Oct 5, 2017

andralex commented Oct 5, 2017

wilzbach commented Oct 5, 2017 •

edited

Loading

andralex commented Oct 5, 2017

wilzbach commented Dec 13, 2017

wilzbach commented Dec 14, 2017

andralex commented Dec 14, 2017

wilzbach commented Dec 15, 2017

wilzbach commented Dec 15, 2017

wilzbach commented Dec 15, 2017

andralex commented Dec 15, 2017

wilzbach commented Dec 15, 2017

andralex commented Dec 15, 2017

andralex commented Dec 15, 2017

RazvanN7 commented Dec 15, 2017

MartinNowak commented Dec 16, 2017

andralex commented Dec 16, 2017

wilzbach commented Dec 16, 2017

ddmd -> dmd transition #7135

ddmd -> dmd transition #7135

Conversation

wilzbach commented Sep 14, 2017 • edited Loading

dlang-bot commented Sep 14, 2017

Bugzilla references

JinShil commented Sep 14, 2017

wilzbach commented Sep 14, 2017

JinShil commented Sep 14, 2017 • edited Loading

wilzbach commented Sep 14, 2017

CyberShadow commented Sep 14, 2017

ibuclaw commented Sep 15, 2017

andralex commented Sep 15, 2017

andralex commented Sep 15, 2017

MartinNowak left a comment

Choose a reason for hiding this comment

ibuclaw commented Sep 23, 2017

wilzbach commented Oct 5, 2017

andralex commented Oct 5, 2017

andralex commented Oct 5, 2017

wilzbach commented Oct 5, 2017 • edited Loading

andralex commented Oct 5, 2017

wilzbach commented Dec 13, 2017

wilzbach commented Dec 14, 2017

andralex commented Dec 14, 2017

wilzbach commented Dec 15, 2017

wilzbach commented Dec 15, 2017

wilzbach commented Dec 15, 2017

andralex commented Dec 15, 2017

wilzbach commented Dec 15, 2017

andralex commented Dec 15, 2017

andralex commented Dec 15, 2017

RazvanN7 commented Dec 15, 2017

MartinNowak commented Dec 16, 2017

andralex commented Dec 16, 2017

wilzbach commented Dec 16, 2017

wilzbach commented Sep 14, 2017 •

edited

Loading

JinShil commented Sep 14, 2017 •

edited

Loading

wilzbach commented Oct 5, 2017 •

edited

Loading