-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddmd -> dmd transition #7135
ddmd -> dmd transition #7135
Conversation
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
If this is to investigate better naming for the compiler-as-a-library API, would it be better to just use the name |
Yes and no. tl;dr: it's picking up an effort to clean up the folder hierarchy started by @RazvanN7 and @andralex half a year ago ( |
7fd1ebe
to
2a51fcd
Compare
2a51fcd
to
c317e74
Compare
Yes, I'm aware of that, but I was questioning the use of |
While I appreciate your input, there have been many lengthy discussions about this and a decision has been made to rename to "dmd": #6489 (comment) Unfortunately the rename was left in stage 2 and I am just trying to take it to the finish line, which sadly is though enough. Also, there are (and hopefully will be) other D compilers which aren't based on the DMD frontend (e.g. SDC), so taking the @CyberShadow regarding:
(this is about the menu generation for the dlang.org (Ddoc version)) |
You're asking the wrong person, DMD docs on dlang.org are mostly pushed by W/A. But I suggest finding a way to do things that doesn't imply that "just break it for now, we'll fix it later", as "later" may be postponed more than expected. Why not detect the name of the DMD package/directory? |
I'd still prefer some agnostic name as per comment I made many months ago in linked pr above. |
It's a nice point but gets us into rebranding the front end. I'd say we move forward with this obvious step and defer that. |
Let's do this already. @MartinNowak ? @WalterBright ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anytime
Just fix the build. |
c317e74
to
126fc85
Compare
126fc85
to
e199efe
Compare
Seems like we need to update the auto-tester again: https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=2816476&dataid=19934733&isPull=true :/ At least CircleCi and Jenkins have been green. |
rebase? |
Let's boldly go see regressions we haven't seen before :). |
I really appreciate the enthusiasm, but we have to wait at least for dlang/dlang.org#1903 and braddr/at-client#4 (no point in constantly rebasing until then). |
Let's hope gain will follow the pain. Thanks for the hard work! (Also please hop on slack.) |
Thanks a lot for pulling this @braddr 🎉 🎂 @ other: FYI I just rebased this PR and it's looking good so far. There were some changes on dlang.org, so we have to update this again (-> dlang/dlang.org#1971), but apart from that, this PR is ready and waiting for the other auto-tester machines to be updated :) |
8552ed4
to
8dedc6b
Compare
4291752
to
7396f68
Compare
Alrighty - this is passing on all auto-tester machines now: According to @braddr
This means in a very foreseeable future we can finally move on with this.
Don't get confused by this. The current stream of merged PRs into dmd is just too high to be able to constantly rebase this. Note that every merge PR will arise a conflict and as soon as we merge this here, all open PRs will have to be rebased once. This is fairly trivial though as git can handle renames quite well. |
7396f68
to
d937ba7
Compare
Can't wait!! |
It looks really good. There are just a few hosts which haven't run these changes yet:
And there seem to be two other other hosts in the list which are solely used to the new FreeBSD OS changes:
But let's better wait for @braddr to give his okay. |
8df0f47
to
cd3ca68
Compare
sed -i "s/ddmd/dmd/g" -i **/*.[cdh]
sed -i "s/ddmd/dmd/g" -i **/*.sdl sed -i "s/ddmd/dmd/g" -i **/*.mak sed -i "s/ddmd/dmd/g" -i **/*.visualdproj sed -i "s/ddmd/dmd/g" -i **/*.vcxproj sed -i "s/ddmd/dmd/g" -i **/*.filters sed -i "s/ddmd/dmd/g" -i CODEOWNERS
cd3ca68
to
cee698b
Compare
Wohoo 🎉 🎈 🎂 Awesome. Thank you so much! |
I just saw @klickverbot's comment from January this year:
... |
So should I force merge this? |
Yes, please. Jenkins is failing due to it running out of space (CC @MartinNowak) and Travis seems to have hit a |
alrighty then |
no mercy |
Awesome. Thanks! |
Nice, a bit unfriendly to merge this just on the beta branch day. |
@MartinNowak sorry, lmk how I can help make things better |
Same here! Did you ran into any issues already? |
Let's see what the missing bits on Windows are.
CC @RazvanN7
Required steps