Skip to content

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented May 30, 2018

Cherry-pick of #8294 for stable; sorry for targeting the wrong branch.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#8312"

@WalterBright
Copy link
Member

I think stable will need #8249 as the boot compiler was upgraded.

@wilzbach
Copy link
Contributor

I think stable will need #8249 as the boot compiler was upgraded.

-> #8314

@wilzbach
Copy link
Contributor

Stable should be green again now.

@dlang-bot dlang-bot merged commit 0c4d5bb into dlang:stable May 31, 2018
@kinke kinke deleted the fix_ice_stable branch May 31, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants