Skip to content

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented May 25, 2018

Seems to fix sporadic segfaults reported in https://issues.dlang.org/show_bug.cgi?id=18864.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8294"

@dlang-bot dlang-bot merged commit c166c30 into dlang:master May 25, 2018
@kinke kinke deleted the fix_ice branch May 25, 2018 21:08
@kinke
Copy link
Contributor Author

kinke commented May 25, 2018

That was quick, thanks; I should have targeted stable though. :/ Pinging @MartinNowak.

@wilzbach
Copy link
Contributor

Ah we typically only do cherry-picking if it's important, so if you feel like this really should be part of 2.080.1, simply cherry-pick and open a new PR.
OTOH the next release will be in one month.

@kinke
Copy link
Contributor Author

kinke commented May 26, 2018

@wilzbach: So a fix for random DMD segfaults isn't important enough to be cherry-picked by one of you guys? What is then? ;)

@dnadlinger
Copy link
Contributor

Sorry about that – I was on my phone, and the mobile version doesn't display the target branch, so I didn't notice.

@wilzbach
Copy link
Contributor

Ehm I'm currently traveling and without laptop, otherwise I would have opened the cherry-pick for you.
Well, Martin always complains about this because these cherry-picks can result in ugly merge conflicts, so yep we often don't bother except for really important things :/

@WalterBright
Copy link
Member

This PR was a bug fix for https://issues.dlang.org/show_bug.cgi?id=18864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants