Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix win64.mak system #6620

Merged
merged 1 commit into from
Mar 12, 2017
Merged

Fix win64.mak system #6620

merged 1 commit into from
Mar 12, 2017

Conversation

e10s
Copy link
Contributor

@e10s e10s commented Mar 11, 2017

Follows up to the new directory structure, related to #6562 and #6610. Note msvc-dmc and msvc-lib binaries are still generated under vcbuild.

@rainers
Copy link
Member

rainers commented Mar 12, 2017

Auto-merge toggled on

@rainers rainers merged commit 269d71b into dlang:master Mar 12, 2017
@rainers
Copy link
Member

rainers commented Mar 12, 2017

Thanks.

There still seems to be an issue (not related to the path changes): Building target dmd works, but building a debug version (the default target) through win64.mak fails: the C compiler options do not match the D compiler option -debug. This causes undefined symbol out_config_debug during link.

@e10s
Copy link
Contributor Author

e10s commented Mar 12, 2017

I've known the problem but it was omitted from this PR for simplicity. I'll send a new PR next time. Thanks for your nice suggestion.

@e10s
Copy link
Contributor Author

e10s commented Mar 12, 2017

#6622

@wilzbach wilzbach mentioned this pull request Dec 15, 2017
Merged
15 tasks
@e10s e10s deleted the fix_win64 branch February 20, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e10s @rainers