Fix agent side test_move_results
#1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
force-pushed
the
fix-test-move-results
branch
2 times, most recently
from
c55cbff to
f728092
Compare
dbutenhof
reviewed
Nov 4, 2020
ndokos
previously approved these changes
Nov 4, 2020
portante
force-pushed
the
fix-test-move-results
branch
2 times, most recently
from
40440d5 to
95f0f59
Compare
npalaska
previously approved these changes
Nov 4, 2020
ndokos
previously approved these changes
Nov 4, 2020
dbutenhof
previously approved these changes
Nov 4, 2020
portante
force-pushed
the
fix-test-move-results
branch
from
95f0f59 to
a720197
Compare
npalaska
previously approved these changes
Nov 4, 2020
ndokos
previously approved these changes
Nov 4, 2020
dbutenhof
previously approved these changes
Nov 5, 2020
While working on PR distributed-system-analysis#1948, refactoring the common logging infrastructure, the tests in `test_move_results` were failing for odd reasons. Looking at them a bit more closely it became apparent the test was not actually invoking the API's PUT method. This commit creates a test that allows the API to be invoked, fixing the move results code to work correctly.
portante
force-pushed
the
fix-test-move-results
branch
from
a720197 to
426fe08
Compare
dbutenhof
approved these changes
Nov 5, 2020
ndokos
approved these changes
Nov 5, 2020
|
Merging without a successful TravisCI since the Jenkins run in #1936 succeeded, and that PR depends on this PR. |
This was referenced Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on PR #1946. The first 3 commits are from that PR.