-
Notifications
You must be signed in to change notification settings - Fork 108
Retooling pbench-move-results to use the RESTful PUT API instead of direct ssh #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retooling pbench-move-results to use the RESTful PUT API instead of direct ssh #2189
Conversation
8ac0ed4
to
e513b7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start, but there is a bunch of polishing which needs to be done.
8426f51
to
e596c34
Compare
This pull request introduces 1 alert when merging e596c34 into dc48a16 - view on LGTM.com new alerts:
|
db70b4a
to
3147ee0
Compare
This pull request introduces 1 alert when merging 3147ee0 into ea02995 - view on LGTM.com new alerts:
|
aeaa633
to
21f97a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good; just want to avoid introducing a new way of handling imports without agreeing on it (see #2238).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
21f97a8
to
510bb37
Compare
Reordered the |
Functional testing, such as it was, is complete. (The server says it's good, unless I upload the same file twice, in which case the tool reports the server's objection.) So, if I can get the nod from @portante and one other person, this PR is good to squash-and-merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the big question of whether Pete wants the 12 commits squashed before hitting the Squash and merge
button?
Not sure why, but it needs a rebase, so might as well rebase and squash it to one commit. |
Create a new, Click-based command which uses the server's HTTP PUT request to upload result tarballs. This command is intended to replace the existing pbench-copy-result-tb script. This commit also includes latent support for a future replacement for the pbench-make-result-tb script and subsequently the pbench-move-results and pbench-copy-results commands.
a6a4ff2
to
c6a7e0b
Compare
I want that button to be useful! (And, I want to avoid the re-approval cycle between the approval and the merge which externally squashing requires.) I wanted to try it to see if it really doesn't work acceptably.... As long as I'm griping, I resent the "Update Branch" button: if I'm going to rebase my branch, then I certainly don't want the outstanding commits from
Ha! 'Cause somebody merged two PRs since I last rebased -- that's why! :-D Anyway, the squash is done, and I'm just prattling on here while I wait for the checks to run.... |
This PR mainly deals with using RESTful PUT API instead of ssh for sending Tarballs from agent to server. At the time of sending of tarballs, it consists of an Authorization token (generated with the help of pbench-generate-token command)which will help for authorizing the owner of the Tarballs.
It uses 'click' for the creation of a command-line interface.
Also consists of config file changes and pytests.
Sorting of the config files is taken care in PR #2190