fix(Action): Don't crash when partials are disabled #4822
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Sep 14, 2020
vladfrangu
requested changes
Sep 14, 2020
src/client/actions/TypingStart.js
Outdated
| handle(data) { | ||
| const channel = this.getChannel(data); | ||
| if (!textBasedChannelTypes.includes(channel.type)) { | ||
| if (channel && !textBasedChannelTypes.includes(channel.type)) { |
Member
There was a problem hiding this comment.
Shouldn't we exit early if no channel is present?
Contributor
Author
There was a problem hiding this comment.
Done. Though that way we don't cache any member data anymore if it's there. Depends on if we want to cache everything we possibly can or are more lax.
Member
There was a problem hiding this comment.
I mean... if we don't have the channel but we cache the member...we still don't emit any events, so I believe it's probably best to exit early. That, of course, is open for discussions tho
vladfrangu
approved these changes
Sep 14, 2020
kyranet
approved these changes
Sep 15, 2020
iCrawl
approved these changes
Sep 15, 2020
1 task
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 1, 2020
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes #4821
this.getMember() returns undefined if there is no cached member and partials are disabled for members.
Also only checks for the correct channel type in TypingStart if there actually is a known channel, I've missed this in my previous PR.
Status
Semantic versioning classification: