TypeError on MESSAGE_REACTION_ADD

[Koyamie]

Please describe the problem you are having in as much detail as possible:
Got few times a TypeError when receiving a MESSAGE_REACTION_ADD event.

Further details:

• discord.js version: latest master
• Node.js version: v12.18.3
• Operating system: debian 9
• Priority this issue should have – please be realistic and elaborate if possible: normal

Relevant client options:

• partials: ['REACTION','MESSAGE']
• gateway intents: 13999
• other: none

• I have also tested the issue on latest master, commit hash:

[monbrey]

Have you tested this with partials enabled for USER and GUILD_MEMBER also?

[Koyamie]

Have you tested this with partials enabled for USER and GUILD_MEMBER also?

Nope, I don't even know in what particular case this does happen.
I only want the REACTION and MESSAGE partials enabled so testing with others doesn't make sense, goal is to fix in this particual case!

[wasdennnoch]

Partials shouldn't make a difference here as the crash occurs before anything with partials was done. It crashes in a code path that's a straight line from the raw gateway event, without any partials branching. That comes after the crash.

[kyranet]

Duplicate of #4821, which has been fixed by #4822.

[Koyamie]

Duplicate of #4821, which has been fixed by #4822.

I am using the very latest version of d.js, this merge inclued.
This means it is not fixed.

[kyranet]

The patch was landed after 12.3.1 landed, if you're using master, can you please provide the commit hash? "Latest master" is ambiguous and may not be actually the latest.

[Koyamie]

Sorry by latest master I mean latest commit, I'm up to date with this commit : 1e63f37

[kyranet]

My bad, I have just confirmed the issue here, I approved the linked PR, sorry for not verifying properly 😅.

[Koyamie]

No problem, will precise the commit next time!