refactor(GuildChannel): rework setting parent and permission locking

src/client/actions/GuildChannelsPositionUpdate.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-depth */
 'use strict';
 
 const Action = require('./Action');
@@ -10,7 +11,26 @@ class GuildChannelsPositionUpdate extends Action {
     if (guild) {
       for (const partialChannel of data.channels) {
         const channel = guild.channels.cache.get(partialChannel.id);
-        if (channel) channel.rawPosition = partialChannel.position;
+        if (channel) {
+          const { position, parent_id, lock_permissions } = partialChannel;
+          if (position) {
+            channel.rawPosition = position;
+          }
+          if (parent_id) {
+            const newParent = guild.channels.cache.get(parent_id);
+            if (newParent) {
+              channel.parentID = parent_id;
+            }
+          }
+          if (lock_permissions) {
+            const newParent = guild.channels.cache.get(parent_id);
+            if (newParent) {
+              channel.permissionOverwrites = newParent.permissionOverwrites.clone();
+            } else if (channel.parent) {
+              channel.permissionOverwrites = channel.parent.permissionOverwrites.clone();
+            }
+          }
+        }
       }
     }
 

src/structures/Guild.js

@@ -1192,7 +1192,9 @@ class Guild extends Base {
    * The data needed for updating a channel's position.
    * @typedef {Object} ChannelPosition
    * @property {ChannelResolvable} channel Channel to update
-   * @property {number} position New position for the channel
+   * @property {number} [position] New position for the channel
+   * @property {?CategoryChannel|Snowflake} [parent] Parent channel
+   * @property {boolean} [lockPermissions] If the permissions should be locked to the parent
    */
 
   /**
@@ -1208,6 +1210,8 @@ class Guild extends Base {
     const updatedChannels = channelPositions.map(r => ({
       id: this.client.channels.resolveID(r.channel),
       position: r.position,
+      parent_id: r.parent !== null ? this.client.channels.resolveID(r.parent) || undefined : null,
+      lock_permissions: r.lockPermissions,
     }));
 
     return this.client.api

typings/index.d.ts

@@ -2173,7 +2173,9 @@ declare module 'discord.js' {
 
   interface ChannelPosition {
     channel: ChannelResolvable;
-    position: number;
+    position?: number;
+    parent?: GuildChannel | Snowflake;
+    lockPermissions?: boolean;
   }
 
   type ChannelResolvable = Channel | Snowflake;