Skip to content

Conversation

@almostSouji
Copy link
Member

@almostSouji almostSouji commented Jun 30, 2020

Please describe the changes this PR makes and why it should be merged:


After some more digging brought up after #4144 this has turned out to be much more of an issue and less of an easy fix as originally assumed. I'll submit this as a draft PR so it can be referenced.

⚠This PR will be subject to heavy changes as more information is acquired!

Current checklist/required information:

Changes:

Alternatives:

Original Issue

The original hacky fix has been moved into #4627 to allow acting faster than the above linked documentation request, should the need arise.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@almostSouji almostSouji deleted the fix-lock-option branch September 27, 2020 10:39
@almostSouji almostSouji restored the fix-lock-option branch September 27, 2020 10:42
@almostSouji almostSouji reopened this Sep 27, 2020
@almostSouji almostSouji changed the title fix(GuildChannel): rework setting parent and permission locking refactor(GuildChannel): rework setting parent and permission locking Jun 13, 2021
@iCrawl iCrawl modified the milestone: Version 13 Jun 27, 2021
@almostSouji
Copy link
Member Author

serves more as a note than as a draft, hence converting to issue #6090

@almostSouji almostSouji deleted the fix-lock-option branch January 7, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants