Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username Docs Updates #6218

Merged
merged 13 commits into from
Jun 7, 2023
Merged

Username Docs Updates #6218

merged 13 commits into from
Jun 7, 2023

Conversation

shaydewael
Copy link
Contributor

@shaydewael shaydewael commented Jun 7, 2023

ok this is just updated #6130 but the branch wasn't syncing correctly so I'm just creating new PR oop.

this no longer includes info specific to bots

edit: ok the PR thing was just related to a Github issue i need to calm down

shaydewael and others added 6 commits May 4, 2023 10:31
Co-authored-by: Florian Spieß <business@minn.dev>
Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>

### Default avatars

For users with migrated accounts, default avatar URLs will be based on the user ID instead of the discriminator. The URL can now be calculated using `(user_id >> 22) % 6`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is % 6 is a typo or was this just changed randomly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was changed. pink avatars now wowwwww yay fun 🌸

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do users with discriminators still use discriminator % 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, for non-migrated users it's still % 5. i can add a note about that until all users are migrated.

docs/Change_Log.md Outdated Show resolved Hide resolved
docs/Reference.md Outdated Show resolved Hide resolved
shaydewael and others added 4 commits June 7, 2023 10:44
Co-authored-by: Florian Spieß <business@minn.dev>
Co-authored-by: Florian Spieß <business@minn.dev>
@TreZc0
Copy link

TreZc0 commented Jun 7, 2023

https://github.com/discord/discord-api-docs/blob/main/docs/resources/User.md

Line 30:
| username | string | the user's username, not unique across the platform | identify |

This is outdated now, right? the username with its new rules should be unique now.
The example below that is also missing the global_user attribute.

@MinnDevelopment
Copy link
Contributor

This is outdated now, right? the username with its new rules should be unique now.

The username won't be unique until all users are migrated. Since bots aren't even getting migrated yet, it's definitely still accurate.

@@ -28,7 +28,8 @@ There are other rules and restrictions not shared here for the sake of spam and
| ------------- | --------- | ---------------------------------------------------------------------------------------------------- | --------------------- |
| id | snowflake | the user's id | identify |
| username | string | the user's username, not unique across the platform | identify |
| discriminator | string | the user's 4-digit discord-tag | identify |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have missed this with the restrictions (or link) at the header New Usernames here.

lukellmann added a commit to kordlib/kord that referenced this pull request Jun 10, 2023
mccoderpy added a commit to mccoderpy/discord.py-message-components that referenced this pull request Jun 11, 2023
discord/discord-api-docs#6218
Signed-off-by: Mathieu Corsham <McCuber04@outlook.de>
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Jun 17, 2023
VelvetToroyashi pushed a commit to VelvetToroyashi/Remora.Discord that referenced this pull request Jun 17, 2023
TTtie added a commit to projectdysnomia/dysnomia that referenced this pull request Jun 18, 2023
* initial unique username system support

* fix up wrong ordering

* add a newline between new member getter

* migrated users have 6 default avatars now

ref: discord/discord-api-docs#6218 (comment)

* emit old globalName in userUpdate

* whoops: global_name -> globalName

* copy note about single "0" discrim to Member.js
TTtie added a commit to projectdysnomia/dysnomia that referenced this pull request Jul 7, 2023
* initial unique username system support

* fix up wrong ordering

* add a newline between new member getter

* migrated users have 6 default avatars now

ref: discord/discord-api-docs#6218 (comment)

* emit old globalName in userUpdate

* whoops: global_name -> globalName

* copy note about single "0" discrim to Member.js
TTtie added a commit to projectdysnomia/dysnomia that referenced this pull request Aug 10, 2023
* initial unique username system support

* fix up wrong ordering

* add a newline between new member getter

* migrated users have 6 default avatars now

ref: discord/discord-api-docs#6218 (comment)

* emit old globalName in userUpdate

* whoops: global_name -> globalName

* copy note about single "0" discrim to Member.js
shaydewael added a commit to Jupith/discord-api-docs that referenced this pull request May 14, 2024
* start username docs

* default avatar

* Update docs/Reference.md

Co-authored-by: Florian Spieß <business@minn.dev>

* Update docs/Change_Log.md

Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>

* fix docs

* reorder

* clarify migrated/legacy

* small changelog clarification

* Update docs/Change_Log.md

Co-authored-by: Florian Spieß <business@minn.dev>

* Update docs/Reference.md

Co-authored-by: Florian Spieß <business@minn.dev>

* oops

* great

---------

Co-authored-by: Florian Spieß <business@minn.dev>
Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants