-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Username Docs Updates #6218
Username Docs Updates #6218
Conversation
Co-authored-by: Florian Spieß <business@minn.dev>
Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>
docs/Change_Log.md
Outdated
|
||
### Default avatars | ||
|
||
For users with migrated accounts, default avatar URLs will be based on the user ID instead of the discriminator. The URL can now be calculated using `(user_id >> 22) % 6`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is % 6 is a typo or was this just changed randomly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was changed. pink avatars now wowwwww yay fun 🌸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do users with discriminators still use discriminator % 5
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, for non-migrated users it's still % 5
. i can add a note about that until all users are migrated.
b7a4d80
to
8c74893
Compare
Co-authored-by: Florian Spieß <business@minn.dev>
Co-authored-by: Florian Spieß <business@minn.dev>
722485f
to
7379fc0
Compare
https://github.com/discord/discord-api-docs/blob/main/docs/resources/User.md Line 30: This is outdated now, right? the username with its new rules should be unique now. |
The username won't be unique until all users are migrated. Since bots aren't even getting migrated yet, it's definitely still accurate. |
@@ -28,7 +28,8 @@ There are other rules and restrictions not shared here for the sake of spam and | |||
| ------------- | --------- | ---------------------------------------------------------------------------------------------------- | --------------------- | | |||
| id | snowflake | the user's id | identify | | |||
| username | string | the user's username, not unique across the platform | identify | | |||
| discriminator | string | the user's 4-digit discord-tag | identify | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discord/discord-api-docs#6218 Signed-off-by: Mathieu Corsham <McCuber04@outlook.de>
* initial unique username system support * fix up wrong ordering * add a newline between new member getter * migrated users have 6 default avatars now ref: discord/discord-api-docs#6218 (comment) * emit old globalName in userUpdate * whoops: global_name -> globalName * copy note about single "0" discrim to Member.js
* initial unique username system support * fix up wrong ordering * add a newline between new member getter * migrated users have 6 default avatars now ref: discord/discord-api-docs#6218 (comment) * emit old globalName in userUpdate * whoops: global_name -> globalName * copy note about single "0" discrim to Member.js
* initial unique username system support * fix up wrong ordering * add a newline between new member getter * migrated users have 6 default avatars now ref: discord/discord-api-docs#6218 (comment) * emit old globalName in userUpdate * whoops: global_name -> globalName * copy note about single "0" discrim to Member.js
* start username docs * default avatar * Update docs/Reference.md Co-authored-by: Florian Spieß <business@minn.dev> * Update docs/Change_Log.md Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com> * fix docs * reorder * clarify migrated/legacy * small changelog clarification * Update docs/Change_Log.md Co-authored-by: Florian Spieß <business@minn.dev> * Update docs/Reference.md Co-authored-by: Florian Spieß <business@minn.dev> * oops * great --------- Co-authored-by: Florian Spieß <business@minn.dev> Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>
ok this is just updated #6130 but the branch wasn't syncing correctly so I'm just creating new PR oop.
this no longer includes info specific to bots
edit: ok the PR thing was just related to a Github issue i need to calm down