gui: fix media eject on linux (#4700) #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removable media is not ejected on linux platform Make get_removable_drive_from_path() check if path is a dir or not. Trim last component in latter case only.
discip
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Update FlyingBear S1 0.4 nozzle.json * Update 0.16mm Optimal @FlyingBear Reborn3.json * Merge pull request #11 from FlyingbearOfficial/FlyingbearOfficial-patch-15 Update 0.16mm Optimal @FlyingBear Reborn3.json * Update 0.16mm Optimal @FlyingBear S1.json * Update fdm_process_common.json * Update fdm_klipper_common.json * Update fdm_machine_common.json * Update fdm_klipper_common.json * Update fdm_machine_common.json * Merge branch 'SoftFever:main' into main * Merge branch 'SoftFever:main' into main * Merge branch 'SoftFever:main' into main * Merge branch 'SoftFever:main' into main * Update fdm_process_common.json * Merge pull request #12 from FlyingbearOfficial/FlyingbearOfficial-patch-16 Update fdm_process_common.json * Update fdm_process_common_S1.json fix some parameters * Update fdm_process_common.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removable media is not ejected on linux platform
Make get_removable_drive_from_path() check if path is a dir or not. Trim last component in latter case only.