Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media is not ejected on Linux #4700

Closed
1 of 3 tasks
buzzhuzz opened this issue Mar 25, 2024 · 2 comments
Closed
1 of 3 tasks

Media is not ejected on Linux #4700

buzzhuzz opened this issue Mar 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@buzzhuzz
Copy link
Contributor

buzzhuzz commented Mar 25, 2024 •
edited
Loading

Is there an existing issue for this problem?

  • I have searched the existing issues

OrcaSlicer Version

v2.0.0-rc,

Operating System (OS)

Linux

OS Version

Ubuntu 23.10 (i3wm, gdm login)

Additional system information

HP Spectre x360-14, i7-1165G7

Printer

Ender3 V3 SE

How to reproduce

Slice the model
Export G-code to removable drive
Press "Eject" button in popup

Actual results

Media is not unmounted

Expected results

Media is unmounted

Project file & Debug log uploads

log.zip

Checklist of files to include

  • Log file
  • Project file

Anything else?

No response
@buzzhuzz buzzhuzz added the bug Something isn't working label Mar 25, 2024
buzzhuzz added a commit to buzzhuzz/OrcaSlicer that referenced this issue Mar 25, 2024
@buzzhuzz
gui: fix media eject on linux (SoftFever#4700)
bd716ea 
Removable media is not ejected on linux platform

Make get_removable_drive_from_path() check if path is a dir or not.
Trim last component in latter case only.
@buzzhuzz
Copy link
Contributor Author

May be related to #2375

discip added a commit to discip/OrcaSlicer that referenced this issue Mar 25, 2024
@discip @buzzhuzz
gui: fix media eject on linux (SoftFever#4700) (#11)
3efa566 
Removable media is not ejected on linux platform

Make get_removable_drive_from_path() check if path is a dir or not.
Trim last component in latter case only.

Co-authored-by: Dima Buzdyk <dima.buzdyk@gmail.com>
@discip discip mentioned this issue Mar 25, 2024
Merged
@buzzhuzz
Copy link
Contributor Author

Cause of the issue in my case is that umount is not getting called since get_removable_drive_from_path() can't find removable device for a given path:

  1. eject_drive() calls set_and_verify_last_save_path(/media/user/A261-2A39)
  2. set_and_verify_last_save_path() calls get_removable_drive_from_path(/media/user/A261-2A39)
  3. within get_removable_drive_from_path() path getting trimmed down to '/media/user' which is is indeed not a removable media
  4. Removable drive lookup failed for '/media/user'

SoftFever pushed a commit that referenced this issue Mar 29, 2024
@buzzhuzz
gui: fix media eject on linux (#4700) (#4701)
45ef4ae 
* gui: fix media eject on linux (#4700)

Removable media is not ejected on linux platform

Make get_removable_drive_from_path() check if path is a dir or not.
Trim last component in latter case only.

* Revert unnecessary style changes
SoftFever pushed a commit that referenced this issue Apr 13, 2024
@buzzhuzz @SoftFever
gui: fix media eject on linux (#4700) (#4701)
7fe017d 
* gui: fix media eject on linux (#4700)

Removable media is not ejected on linux platform

Make get_removable_drive_from_path() check if path is a dir or not.
Trim last component in latter case only.

* Revert unnecessary style changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@buzzhuzz