Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major bump to comment lines ratio #73

Merged
Prev Previous commit
Next Next commit
events comments
  • Loading branch information
jaketimothy committed Jun 15, 2023
commit fcbbf8e5af9590be91ed36bca9abfe96d505340f
2 changes: 2 additions & 0 deletions src/issuer/DirectBuyIssuer.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ contract DirectBuyIssuer is BuyOrderIssuer {

error UnreturnedEscrow();

/// @dev Emitted when `amount` of escrowed payment is taken for `orderId`
event EscrowTaken(bytes32 indexed orderId, address indexed recipient, uint256 amount);
/// @dev Emitted when `amount` of escrowed payment is returned for `orderId`
event EscrowReturned(bytes32 indexed orderId, address indexed recipient, uint256 amount);

/// ------------------ State ------------------ ///
Expand Down
1 change: 1 addition & 0 deletions src/issuer/OrderFees.sol
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ contract OrderFees is Ownable2Step, IOrderFees {
error FeeTooLarge();
error DecimalsTooLarge();

/// @dev Emitted when `perOrderFee` and `percentageFeeRate` are set
event FeeSet(uint64 perOrderFee, uint64 percentageFeeRate);

/// ------------------ Constants ------------------ ///
Expand Down
6 changes: 4 additions & 2 deletions src/issuer/OrderProcessor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,11 @@ abstract contract OrderProcessor is
error DuplicateOrder();
error AmountTooLarge();

// Events
/// @dev Emitted when `treasury` is set
event TreasurySet(address indexed treasury);
event OrderFeesSet(IOrderFees orderFees);
/// @dev Emitted when `orderFees` is set
event OrderFeesSet(IOrderFees indexed orderFees);
/// @dev Emitted when orders are paused/unpaused
event OrdersPaused(bool paused);

/// ------------------ Constants ------------------ ///
Expand Down
3 changes: 2 additions & 1 deletion test/SellOrderProcessor.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import "openzeppelin-contracts/contracts/proxy/ERC1967/ERC1967Proxy.sol";
import "./utils/mocks/MockBridgedERC20.sol";
import "./utils/SigUtils.sol";
import "../src/issuer/SellOrderProcessor.sol";
import {OrderFees} from "../src/issuer/OrderFees.sol";
import "../src/issuer/IOrderBridge.sol";
import {OrderFees, IOrderFees} from "../src/issuer/OrderFees.sol";
import "openzeppelin-contracts/contracts/utils/Strings.sol";

contract SellOrderProcessorTest is Test {
Expand Down