Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major bump to comment lines ratio #73

Merged

Conversation

jaketimothy
Copy link
Contributor

@jaketimothy jaketimothy commented Jun 15, 2023

Make it look professional for audit and release.

Not yet at 8/10 ratio

@jaketimothy
Copy link
Contributor Author

@jaketimothy jaketimothy changed the title 80 percent comment lines to code lines ratio Major bump to comment lines ratio Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #73 (7925f57) into main (f1ad904) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7925f57 differs from pull request most recent head 9d3878f. Consider uploading reports for the commit 9d3878f to get more accurate results

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files           7        7           
  Lines         202      204    +2     
  Branches       44       44           
=======================================
+ Hits          201      203    +2     
  Partials        1        1           
Impacted Files Coverage Δ
src/BridgedERC20.sol 100.00% <ø> (ø)
src/TransferRestrictor.sol 100.00% <ø> (ø)
src/issuer/BuyOrderIssuer.sol 97.61% <ø> (ø)
src/issuer/OrderFees.sol 100.00% <ø> (ø)
src/issuer/SellOrderProcessor.sol 100.00% <ø> (ø)
src/issuer/DirectBuyIssuer.sol 100.00% <100.00%> (ø)
src/issuer/OrderProcessor.sol 100.00% <100.00%> (ø)

@jaketimothy jaketimothy merged commit 9e62f88 into main Jun 15, 2023
@jaketimothy jaketimothy deleted the jake/CU-8684udrq2-80-comment-lines-to-code-lines-ratio branch June 15, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant