Profiling support #743
Open
Profiling support #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Sep 27, 2024
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "rust-analyzer.cargo.features": [ | |||
| "simd-stable" | |||
| "simd-stable", | |||
| "dim3" | |||
There was a problem hiding this comment.
this is not needed, but not an entirely bad thing 🤔 ; should we ignore this file in gitignore though ?
Vrixyz
commented
Sep 27, 2024
| @@ -21,6 +27,7 @@ anyhow = "1" | |||
| bitflags = "2" | |||
| # NOTE: we are not using the (more recent) urdf-rs crate because of https://github.com/openrr/urdf-rs/issues/94 | |||
| xurdf = "0.2" | |||
| profiling = "1.0" | |||
There was a problem hiding this comment.
I added the profiling dependency there but I think I didn´t mark any functions
Vrixyz
commented
Sep 27, 2024
| @@ -1552,6 +1552,7 @@ fn update_testbed( | |||
| if state.running == RunMode::Step { | |||
| state.running = RunMode::Stop; | |||
| } | |||
| profiling::finish_frame!(); | |||
There was a problem hiding this comment.
profiling::finish_frame!(); belongs here (in user code), as rapier isn't strictly the owner of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses https://crates.io/crates/profiling so we can choose any supported profiling options. This is also helpful for users to get an understanding of performances.
using tracy on all_examples3 (
cargo run --bin all_examples3 --features profiling/profile-with-tracy)Should we remove
countersfrom rapier ? I imagine it would be great to be able to output the same kind of csv we're doing currently, but using this profiling option.