Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Is
Build sorted particle-to-cell incidence once per tear and use it for fans, membership checks, and bounded connectivity searches. Keep the index in
SplitLog, update it as cells move to particle copies, and discard it after tearing. Cuts, non-cell bodies, and repeated-vertex cells keep the scanning path.Why
Addresses the repeated whole-body cell lookups reported in #1035, using the incidence approach proposed there. Cell ordering and topology stay unchanged. There is no public API or snapshot-format change; remaining edge/boundary scans are not removed.
Tophat E2E
Release builds on Apple M1 macOS, compared with current master. Four alternating baseline/candidate rounds, seven fresh-world trials per fixture:
All 24 fixtures match event, topology, and post-simulation fingerprints; 17 perform actual tearing. Each checks conservation and runs three subsequent physics steps. Timings exclude construction and those steps, not total step time or rendering FPS.
Verification
no_std + allocbuilds, formatting, andgit diff --checkpass.