Merge pull request #529 from Linentio/master

Use the absolute value of the up attribute when calculating up_extent and side_extent
dimforge · Oct 1, 2023 · 82416e3 · 82416e3
2 parents dfb4f2a + 6c901d5
commit 82416e3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/control/character_controller.rs b/src/control/character_controller.rs
@@ -521,8 +521,8 @@ impl KinematicCharacterController {
 
     fn compute_dims(&self, character_shape: &dyn Shape) -> Vector2<Real> {
         let extents = character_shape.compute_local_aabb().extents();
-        let up_extent = extents.dot(&self.up);
-        let side_extent = (extents - *self.up * up_extent).norm();
+        let up_extent = extents.dot(&self.up.abs());
+        let side_extent = (extents - (*self.up).abs() * up_extent).norm();
         Vector2::new(side_extent, up_extent)
     }
 
@@ -679,7 +679,7 @@ impl KinematicCharacterController {
         filter: QueryFilter,
     ) {
         let extents = character_shape.compute_local_aabb().extents();
-        let up_extent = extents.dot(&self.up);
+        let up_extent = extents.dot(&self.up.abs());
         let movement_to_transfer =
             *collision.toi.normal1 * collision.translation_remaining.dot(&collision.toi.normal1);
         let prediction = self.predict_ground(up_extent);