Make nphysics compatible with projects depending on wasm-bindgen #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhohenheim
commented
Sep 13, 2018
| @@ -140,7 +148,7 @@ pub mod math { | |||
| use algebra::{Force3, Inertia3, Velocity3}; | |||
| use na::{ | |||
| Dynamic, Isometry3, Matrix3, Matrix6, MatrixMN, MatrixSlice6xX, MatrixSliceMut6xX, Point3, | |||
| Translation3, U3, U6, UnitQuaternion, Vector3, Vector6, | |||
| Translation3, UnitQuaternion, Vector3, Vector6, U3, U6, | |||
There was a problem hiding this comment.
These changes are due to my automatic rustfmt
janhohenheim
commented
Sep 13, 2018
| @@ -217,7 +225,7 @@ pub mod math { | |||
| use algebra::{Force2, Inertia2, Velocity2}; | |||
| use na::{ | |||
| Dynamic, Isometry2, Matrix1, Matrix3, MatrixMN, MatrixSlice3xX, MatrixSliceMut3xX, Point2, | |||
| Translation2, U1, U2, U3, UnitComplex, Vector1, Vector2, Vector3, | |||
| Translation2, UnitComplex, Vector1, Vector2, Vector3, U1, U2, U3, | |||
There was a problem hiding this comment.
These changes are due to my automatic rustfmt
janhohenheim
commented
Sep 13, 2018
| target_arch = "asmjs" | ||
| ) | ||
| )] | ||
| #[cfg(all( |
There was a problem hiding this comment.
I simplified this code a bit while I working on the file.
janhohenheim
added a commit
to myelin-ai/myelin
that referenced
this pull request
Sep 13, 2018
|
Thanks, I have not tried wasm-bindgen yet! I will test/merge this tomorrow morning. |
|
I can recommend it. Being able to use Rusts type system with all JS calls and the entire DOM API is really nice and became my favourite way to create UIs in Rust. |
|
Everything seems good. Thanks! |
janhohenheim
added a commit
to myelin-ai/myelin
that referenced
this pull request
Sep 16, 2018
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
added a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
added a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
jeremystucki
pushed a commit
to myelin-ai/engine
that referenced
this pull request
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, projects depending on wasm-bindgen cannot use nphysics due to a transcient dependency on stdweb.
This PR adds a new feature,
use-wasm-bindgen, which useswasm-bindgeninstead. This is a non-breaking change, as all dependencies onstdwebhave been moved to the specialstandardfeature.