-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features required by rusty-machine. #499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be slightly more idiomatic to name these iterators Rows
& RowsMut
, and Cols
and ColsMut
.
Some examples of this pattern in the standard library include Chars
and Values
and ValuesMut
.
@jswrenn I believe the convention is for the iterator type to have the same name as the method returning it. In our case the methods are I didn't call those methods |
I forgot about those methods! You're right about the convention. The name conflict is unfortunate. |
d7ab0d8
to
dcae274
Compare
I'm merging this for today's release. |
See #498.