Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant import errors in nalgebra-glm #1371

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

yotamofek
Copy link
Contributor

More fallout from rust-lang/rust#121708
Should make CI green again

More fallout from rust-lang/rust#121708
Should make CI green again
@Andlon
Copy link
Collaborator

Andlon commented Mar 20, 2024

Thanks for figuring out the cause of this @yotamofek! I'm unsure why this compiles though. There's a call to na::zero on Line 7. How does this compile without na having been explicitly imported? What am I missing?

@Andlon
Copy link
Collaborator

Andlon commented Mar 20, 2024

Ah, I see; it's because of extern crate nalgebra as na; in lib.rs. OK, I guess it should be safe to merge as far as I can tell.

@tpdickso: you've been looking into this issue. Does this adequately fix the issue or can you think of any lingering problems?

@tpdickso
Copy link
Collaborator

@Andlon The top-level crate has extern nalgebra as na; which is sufficient to put it in the namespace, and is what made the use na; in the file redundant in the first place.

Anyway, this is good to merge! I don't expect it to fix the other redundant import issues which were being caused by an "invisible" use na; on line 2 of several other files -- but those seem to have resolved themselves, perhaps with a version bump of xargo or something.

@tpdickso tpdickso merged commit 990afe6 into dimforge:dev Mar 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants