Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rapier-debug-render feature #583

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

jeyum2
Copy link
Contributor

@jeyum2 jeyum2 commented Sep 2, 2024

Provide features to enable rapier/debug-render when implementing custom debug render instead of bevy's

Provide features to enable `rapier/debug-render` when implementing custom debug render
@Vrixyz
Copy link
Contributor

Vrixyz commented Sep 6, 2024

To be sure, this is currently possible by adding explicitly rapier in the dependencies, and activating the feature from it, correct?

This PR allows to add this feature in a more straightforward manner. OK for me :)

@Vrixyz Vrixyz self-requested a review September 6, 2024 09:05
@Vrixyz
Copy link
Contributor

Vrixyz commented Sep 6, 2024

To be correct, shouldn´t the rapier dependency not bring that feature by default ?

rapier debug-render feature isn´t enabled by default 👌

@jeyum2
Copy link
Contributor Author

jeyum2 commented Sep 6, 2024

To be sure, this is currently possible by adding explicitly rapier in the dependencies, and activating the feature from it, correct?

This PR allows to add this feature in a more straightforward manner. OK for me :)

Of course, it works if you add the same version of rapier used by bevy_rapier as a dependency, but if you use a different version, there's a risk of unexpected behavior.
To prevent this and keep consistency, I think it would be better for bevy_rapier to export the debug-render features.

@Vrixyz Vrixyz merged commit 8d10abc into dimforge:master Sep 9, 2024
4 checks passed
jeyum2 added a commit to jeyum2/bevy_rapier that referenced this pull request Sep 10, 2024
Provide features to enable `rapier/debug-render` when implementing custom debug render

---------

Co-authored-by: Thierry Berger <contact@thierryberger.com>
@jeyum2 jeyum2 deleted the custom-debug-render branch September 12, 2024 04:29
@jeyum2 jeyum2 changed the title Add custom-debug-render feature Add rapier-debug-render feature Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants