Reverse Job Card Buttons

[conroy-ricketts]

Not Yet Ready For Merge!

Product Description

There's no ticket for this. As requested by Brendon in this Slack thread, I reversed the buttons on the job card, along with their color schemes. I also added a conditional download icon to the "Resume" button.

To quote Brendon:

The Resume button should be on the left and the View Info button should be on the right, to maintain consistency. However, in the context of the overview screen, the View Info button is the primary action so it should take the primary colour... we'll need to contextually add the download icon to this Resume button as well.

Before screenshot:

After screenshot:

After screenshot with download button (this is for demonstration purposes only - this icon will be updated after we merge in #3484):

TODO:

• Use the correct icon on the Resume button.
• Update the button sizes to match Redesign opportunity card on connect landing page #3484.

Safety Assurance

Safety story

I verified that...

• The buttons still work as expected.
• The download icon only shows when the CC app has not been installed yet.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR updates the job card UI layout by renaming button IDs (mb_view_info to mb_resume and vice versa) and adding visual indicators for app installation status. The layout XML now includes icon attributes for the resume button. Corresponding changes in ConnectDeliveryProgressFragment and ConnectLearningProgressFragment implement conditional icon display logic: when an app is not installed, a download icon appears on the resume button; otherwise, no icon is shown.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• CCCT-2035 Job Card Overlapping UI #3497 — Modifies the same view_job_card.xml buttons and layout constraints for mb_resume/mb_view_info elements
• CCCT-2002 Opportunity Card Redesign #3473 — Updates the same fragments and job card UI elements with button ID changes and behavior modifications
• Learn-to-deliver transition improvement #2924 — Modifies the view_job_card.xml layout and ConnectLearningProgressFragment UI behavior

Suggested labels

Release Note, QA Note

Suggested reviewers

• Jignesh-dimagi
• jaypanchal-13
• OrangeAndGreen
• shubham1g5

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description covers Product Description with context and screenshots, and includes Safety Assurance with verification notes, but lacks Technical Summary with ticket/rationale link, Feature Flag section, detailed Automated test coverage, QA Plan, and required label checkboxes.	Add Technical Summary linking to the Slack discussion or any related documentation, specify automated test coverage, provide QA plan details, and include the label checklist items required by the template.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title "Reverse Job Card Buttons" accurately captures the main change: reversing the order and color schemes of the job card buttons.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch no-ticket/reverse-job-card-buttons

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}