CCCT-2035 Job Card Overlapping UI

[conroy-ricketts]

CCCT-2035

Product Description

This one is pretty straightforward from the ticket - I constrained the buttons to the bottom of delivery hours and added a bit of margin.

I might update this PR if Product wants me to adjust the margin.

Here is a before example:

And here is an after image:

If delivery hours are not included, this is what the UI looks like with these changes:

Safety Assurance

Safety story

I tested these changes on different pages with and without delivery hours to make sure the UI looks solid.

QA Plan

We should test to ensure that the delivery hours is no longer being overlapped in the UI.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request modifies the view_job_card.xml layout file to adjust vertical spacing and reposition UI elements. The changes reduce spacing for two elements from 20dp to 5dp, update constraint references to anchor elements below tv_job_time instead of tv_job_description, and add top margins to other elements for improved visual separation. These are layout adjustments only with no functional logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• OrangeAndGreen
• shubham1g5
• Jignesh-dimagi
• jaypanchal-13

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description includes Product Description with visual examples, Safety Assurance with testing details, and a QA Plan. However, it lacks Technical Summary with ticket link/rationale, Feature Flag section, Automated test coverage, and complete Labels checklist.	Add a Technical Summary section explaining the design rationale, confirm which labels are actually set, and specify what automated test coverage exists or should be added to validate the layout changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly and specifically references the bug ticket (CCCT-2035) and describes the main issue being fixed (job card overlapping UI).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bug/CCCT-2035-job-card-overlapping-ui

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[OrangeAndGreen]

Looks good to me, although it might be nice to also include a screenshot of the UI when delivery hours aren't included.

[conroy-ricketts]

Looks good to me, although it might be nice to also include a screenshot of the UI when delivery hours aren't included.

@OrangeAndGreen Good call, adding that now

[conroy-ricketts]

I tweaked the margin and updated the screenshots a moment ago