-
-
Notifications
You must be signed in to change notification settings - Fork 45
Changed app version to 2.60 in manifest #3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release-blocker: Bump android:versionCode for Play upload
Updating only versionName will not be accepted by Play if versionCode remains 106; every release must increment versionCode. Recommend setting it to 107 (or next unused integer per your release train).
Apply this diff:
📝 Committable suggestion
🤖 Prompt for AI Agents
💡 Verification agent
🧩 Analysis chain
Verify the manifest is the source of truth (Gradle can override these)
Many Android builds set versionCode/versionName in build.gradle(defaultConfig). If that’s the case here, this manifest change will be ignored. Please confirm there are no overrides in Gradle or flavors.
Run from repo root:
🏁 Script executed:
Length of output: 750
Manifest version values are being overridden by Gradle defaultConfig – please fix
We discovered that your
AndroidManifest.xmlentries…android:versionCode="106"android:versionName="2.60"…are effectively ignored at build time because in app/build.gradle (around line 290) you have:
defaultConfig { // … versionCode 1 // (no versionName set here) // … }This means:
versionCode 1instead of106, so your manifest bump to 106 has no effect.versionNameisn’t set in Gradle, only the manifest’s2.60will be used—but best practice is to manage both in Gradle for consistency.To resolve:
• Option A – Define both values in Gradle and remove them from the manifest
• Option B – Keep definitions in the manifest and remove overrides from Gradle
Also double-check any productFlavor or buildType blocks for further
versionCode/versionNameoverrides.🤖 Prompt for AI Agents