Changed app version to 2.60 in manifest #3306
Conversation
📝 WalkthroughWalkthroughUpdated Android app manifest versioning: android:versionName changed from "2.59.0" to "2.60" in app/AndroidManifest.xml. android:versionCode remains 106. No other manifest entries were modified. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
app/AndroidManifest.xml (1)
5-5: Keep versionName format consistent (2.60 vs 2.60.0)Previous release used "2.59.0". For consistency and tooling that parses semver, consider "2.60.0" instead of "2.60". If the team intentionally dropped the patch digit, ignore.
Optional diff:
- android:versionName="2.60"> + android:versionName="2.60.0">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
app/AndroidManifest.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Lint Code Base
| android:versionCode="106" | ||
| android:versionName="2.59.0"> | ||
| android:versionName="2.60"> |
There was a problem hiding this comment.
Release-blocker: Bump android:versionCode for Play upload
Updating only versionName will not be accepted by Play if versionCode remains 106; every release must increment versionCode. Recommend setting it to 107 (or next unused integer per your release train).
Apply this diff:
- android:versionCode="106"
- android:versionName="2.60">
+ android:versionCode="107"
+ android:versionName="2.60">📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| android:versionCode="106" | |
| android:versionName="2.59.0"> | |
| android:versionName="2.60"> | |
| android:versionCode="107" | |
| android:versionName="2.60"> |
🤖 Prompt for AI Agents
In app/AndroidManifest.xml around lines 4 to 5, the android:versionCode is still
106 which blocks Play upload because versionCode must be incremented for each
release; update android:versionCode to the next integer (e.g., 107) while
keeping android:versionName as desired, save the manifest, and verify the build
uses the updated manifest before submitting to the Play Console.
💡 Verification agent
🧩 Analysis chain
Verify the manifest is the source of truth (Gradle can override these)
Many Android builds set versionCode/versionName in build.gradle(defaultConfig). If that’s the case here, this manifest change will be ignored. Please confirm there are no overrides in Gradle or flavors.
Run from repo root:
🏁 Script executed:
#!/bin/bash
# Find any Gradle overrides of versionCode/versionName
rg -nP -C2 '^\s*version(Code|Name)\s' --glob '!**/build/**' --type-add 'gradle:*.gradle' --type-add 'kts:*.kts' --type gradle --type kts
echo "Manifest occurrences:"
rg -nP -C1 'android:(versionCode|versionName)=' app/src/main/AndroidManifest.xml app/AndroidManifest.xml 2>/dev/null || trueLength of output: 750
Manifest version values are being overridden by Gradle defaultConfig – please fix
We discovered that your AndroidManifest.xml entries…
android:versionCode="106"android:versionName="2.60"
…are effectively ignored at build time because in app/build.gradle (around line 290) you have:
defaultConfig {
// …
versionCode 1
// (no versionName set here)
// …
}This means:
- Gradle uses
versionCode 1instead of106, so your manifest bump to 106 has no effect. - Since
versionNameisn’t set in Gradle, only the manifest’s2.60will be used—but best practice is to manage both in Gradle for consistency.
To resolve:
• Option A – Define both values in Gradle and remove them from the manifest
--- a/app/build.gradle
+++ b/app/build.gradle
defaultConfig {
- versionCode 1
+ versionCode 106
+ versionName "2.60"
// …
}--- a/app/AndroidManifest.xml
+++ b/app/AndroidManifest.xml
- android:versionCode="106"
- android:versionName="2.60"• Option B – Keep definitions in the manifest and remove overrides from Gradle
--- a/app/build.gradle
+++ b/app/build.gradle
defaultConfig {
- versionCode 1
+ // versionCode/versionName managed in AndroidManifest.xml
// …
}Also double-check any productFlavor or buildType blocks for further versionCode/versionName overrides.
🤖 Prompt for AI Agents
In app/AndroidManifest.xml around lines 4-5 the manifest sets
android:versionCode="106" and android:versionName="2.60" but these are being
overridden by app/build.gradle defaultConfig (versionCode 1) so the manifest
changes have no effect; fix by moving versionCode and versionName management to
Gradle (preferred): set both versionCode and versionName in app/build.gradle
defaultConfig (and remove them from AndroidManifest.xml), or alternatively
remove the overrides from Gradle so the manifest values are used; also scan
productFlavors and buildType blocks for any additional versionCode/versionName
overrides and reconcile them.
avazirna
left a comment
avazirna
left a comment
There was a problem hiding this comment.
This issue keeps happening. But I think it's more relevant to Windows machine, can you link me to your notes?
Manually bumping app version to 2.60 after 2.59 release (I think a script was supposed to do this?)