Skip to content

Solved progress display error while navigating from payment tab in delivery progress screen #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pm-dimagi merged 2 commits into from
Jul 18, 2025
Merged

Solved progress display error while navigating from payment tab in delivery progress screen #3257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5937d3a
Solved progress display error while navigating from payment tab in de…
Jul 18, 2025
4e34d77
Changes as per comment -1
Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/src/org/commcare/fragments/connect/ConnectDeliveryProgressDeliveryFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,16 @@ private HashMap<String, HashMap<String, Integer>> getStatusMap(ConnectJobRecord
return statusMap;
}


/**
* This was added to re-calculate the correct height of a fragment in ViewPager2. This is required as ViewPager2
* has bug currently due to which it's not calculating the height of it's different fragment correctly.
* When found some other solution for this ViewPager2 bug, we can remove this but make sure to QA
* by pressing sync button while in different fragments.
*/
@Override
public void onResume() {
super.onResume();
binding.getRoot().requestLayout();
Copy link
Contributor

@shubham1g5 shubham1g5 Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jignesh-dimagi can you proide a technical description of the root cause in the PR description along with how this fixes this issue.

Copy link
Contributor Author

@Jignesh-dimagi Jignesh-dimagi Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham1g5 There seems some issue with ViewPager2 in calculating the dynamic height after the data are reloaded, it requires some kind of recalculation, may be this is the one way to do that. This works here but not sure if this is the best way.

Copy link
Contributor

@shubham1g5 shubham1g5 Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, can we add a code comment here for this, for someone looking at this code to know this is due to a viewpager 2 bug and if we remove it what exactly should we be testing to make sure the removal is safe.

}
}